Skip to content

Fixed CompletionItem.text re-populating from value after being cleared.#1641

Merged
kmvanbrunt merged 2 commits intomainfrom
fix_completion_bug
Apr 20, 2026
Merged

Fixed CompletionItem.text re-populating from value after being cleared.#1641
kmvanbrunt merged 2 commits intomainfrom
fix_completion_bug

Conversation

@kmvanbrunt
Copy link
Copy Markdown
Member

@kmvanbrunt kmvanbrunt commented Apr 20, 2026

No description provided.

@kmvanbrunt kmvanbrunt requested a review from tleonhardt as a code owner April 20, 2026 08:53
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.51%. Comparing base (143a99e) to head (5cb18a7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1641   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          21       21           
  Lines        4726     4729    +3     
=======================================
+ Hits         4703     4706    +3     
  Misses         23       23           
Flag Coverage Δ
unittests 99.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmvanbrunt kmvanbrunt mentioned this pull request Apr 20, 2026
20 tasks
@kmvanbrunt kmvanbrunt marked this pull request as draft April 20, 2026 09:41
@kmvanbrunt kmvanbrunt changed the title Fixed not being able to clear CompletionItem.text. Fixed CompletionItem.text re-populating from value after being cleared. Apr 20, 2026
Comment thread cmd2/completion.py
@kmvanbrunt kmvanbrunt marked this pull request as ready for review April 20, 2026 18:50
@kmvanbrunt kmvanbrunt merged commit 66a6a57 into main Apr 20, 2026
33 checks passed
@kmvanbrunt kmvanbrunt deleted the fix_completion_bug branch April 20, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants