fix 'next' link href when OPTIMIZE_PAGINATION_FOR_SPEED is true#1567
Closed
eukaryote wants to merge 1 commit intopyeve:masterfrom
Closed
fix 'next' link href when OPTIMIZE_PAGINATION_FOR_SPEED is true#1567eukaryote wants to merge 1 commit intopyeve:masterfrom
eukaryote wants to merge 1 commit intopyeve:masterfrom
Conversation
eukaryote
force-pushed
the
fix-next-link-with-optimize-pagination-for-speed
branch
2 times, most recently
from
b6d1adc to
eea66b8
Compare
- add a test and a fix for the 'next' link incorrectly including a document id in the href when paginating through collections when OPTIMIZE_PAGINATION_FOR_SPEED is true; the next link was being generated in the form "<resource>/<id>?page=2" instead of the correct "<resource>?page=2".
eukaryote
force-pushed
the
fix-next-link-with-optimize-pagination-for-speed
branch
from
eea66b8 to
a940587
Compare
Member
|
Hey thanks, it looks good to me. I appreciate the AI disclosure, and the context around it. |
nicolaiarocci
added a commit
that referenced
this pull request
Feb 11, 2026
Member
|
rebased and merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test and a fix for the
nextlink incorrectly including a document id in thehrefwhen paginating through collections whenOPTIMIZE_PAGINATION_FOR_SPEEDis true; the next link was being generated in the form<resource>/<id>?page=2instead of the correct<resource>?page=2.AI disclosure: the fix and the test were created by Claude. I don't have mongo available or all the necessary python versions for testing, so I'm making this a draft PR so that I can verify all the tests/checks pass before marking it as ready to review.