Consider urllib3 version has 3 numbers at most (#7375)#7376
Merged
nateprewitt merged 1 commit intopsf:mainfrom Apr 20, 2026
Merged
Consider urllib3 version has 3 numbers at most (#7375)#7376nateprewitt merged 1 commit intopsf:mainfrom
nateprewitt merged 1 commit intopsf:mainfrom
Conversation
nateprewitt
approved these changes
Apr 20, 2026
Member
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
This seems reasonable for uniformity. Thanks @dsanader!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle the urllib3 string version the same way it is done for chardet or charset-normalizer.
It avoids the version check from failing if the split generates a list of size > 3.
Fixes #7375