Skip to content

Add getFunction calls for endianness test function signatures#534

Merged
leonm1 merged 2 commits intoproxy-wasm:mainfrom
leonm1:fix/null-build
Apr 1, 2026
Merged

Add getFunction calls for endianness test function signatures#534
leonm1 merged 2 commits intoproxy-wasm:mainfrom
leonm1:fix/null-build

Conversation

@leonm1
Copy link
Copy Markdown
Contributor

@leonm1 leonm1 commented Mar 30, 2026

These missing functions (added through the new function call types in #525) result in the following linker error when compiling against NullVM:

ld: error: undefined symbol: proxy_wasm::NullPlugin::getFunction(std::__u::basic_string_view<char, std::__u::char_traits<char>>, std::__u::function<proxy_wasm::Word (proxy_wasm::ContextBase*, proxy_wasm::Word, unsigned long, float, double)>*)
>>> referenced by null_plugin.cc
>>>               blaze-out/k8-fastbuild/_objs/null_lib/null_plugin.pic.o:(vtable for proxy_wasm::NullPlugin)

ld: error: undefined symbol: proxy_wasm::NullPlugin::getFunction(std::__u::basic_string_view<char, std::__u::char_traits<char>>, std::__u::function<unsigned long (proxy_wasm::ContextBase*, float)>*)
>>> referenced by null_plugin.cc
>>>               blaze-out/k8-fastbuild/_objs/null_lib/null_plugin.pic.o:(vtable for proxy_wasm::NullPlugin)

ld: error: undefined symbol: proxy_wasm::NullPlugin::getFunction(std::__u::basic_string_view<char, std::__u::char_traits<char>>, std::__u::function<float (proxy_wasm::ContextBase*, float, float)>*)
>>> referenced by null_plugin.cc
>>>               blaze-out/k8-fastbuild/_objs/null_lib/null_plugin.pic.o:(vtable for proxy_wasm::NullPlugin)

ld: error: undefined symbol: proxy_wasm::NullPlugin::getFunction(std::__u::basic_string_view<char, std::__u::char_traits<char>>, std::__u::function<double (proxy_wasm::ContextBase*, float, float, float)>*)
>>> referenced by null_plugin.cc
>>>               blaze-out/k8-fastbuild/_objs/null_lib/null_plugin.pic.o:(vtable for proxy_wasm::NullPlugin)
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@PiotrSikora
Copy link
Copy Markdown
Member

Could we figure out a test to fix / detect this in this repo? It's the reason for the majority of build errors.

@leonm1
Copy link
Copy Markdown
Contributor Author

leonm1 commented Mar 30, 2026

Could we figure out a test to fix / detect this in this repo? It's the reason for the majority of build errors.

I plan to do so.

Signed-off-by: Matt Leon <mattleon@google.com>
@leonm1 leonm1 enabled auto-merge (squash) April 1, 2026 13:31
@leonm1 leonm1 merged commit 3930b7b into proxy-wasm:main Apr 1, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants