Conversation
Closes: prometheus#687 Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com>
|
@beorn7 This is still using the up/down caret icons from the bootstrap4-glyphicons set. I wasn't sure if we also want to replace them with something modern. We could possibly ditch them altogether if we use the accordion component, which seems to have its own up/down caret toggle icons. Also, we're still depending on jQuery for the XHR stuff and a bit of DOM manipulation in |
|
I don't have strong feelings here. But this should be reviewed/decided by the new maintainers @jan--f and @machine424 . |
|
And thanks for doing this work. |
jan--f
left a comment
jan--f
left a comment
There was a problem hiding this comment.
Generally this looks pretty good. I have one question below.
I think both you suggestions (the glyphicon and jquery dependecy) would make good follow ups. Would you perhaps even be interested in adding those?
| success: function(data, textStatus, jqXHR) { | ||
| pushgateway.panel.remove(); | ||
| pushgateway.decreaseDelAllCounter(); | ||
| $('#del-modal').modal('hide'); |
There was a problem hiding this comment.
Does this need the same change as lines 34 and 42?
| } | ||
| }); | ||
| pushgateway.setDelAllCounter(0); | ||
| $('#del-all-modal').modal('hide'); |
3 participants
Replace deprecated Bootstrap v4 library with v5.
Closes: #687