Add direct link to integration workflow in PR comments#7637
Add direct link to integration workflow in PR comments#7637liuliu-dev wants to merge 1 commit intomainfrom
Conversation
|
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Action that recommends integration testing so its PR comment includes a direct link to the github/github-ui integration workflow, while still linking to the existing step-by-step docs.
Changes:
- Replace the “integration workflow” link in the bot comment with a direct link to the
github/github-uiActions workflow. - Add an explicit link to the integration testing documentation alongside the workflow link (in both comment variants).
Comments suppressed due to low confidence (1)
.github/workflows/recommend-integration-tests.yml:70
- Same duplication issue as above: this second createComment body repeats the full message. Extracting a shared constant/template for the comment text would reduce maintenance cost and ensure both branches stay in sync.
...issue,
body: '<!-- recommend-integration-tests.yml -->\n\n # ⚠️ Action required \n\n :wave: Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the [integration workflow](https://github.com/github/github-ui/actions/workflows/primer-react-pr-test.yml). Check the [integration testing docs](https://gh.io/testing_primer_at_dotcom) for step-by-step instructions. Or, apply the `integration-tests: skipped manually` label to skip these checks.'
})
| ...issue, | ||
| body: '<!-- recommend-integration-tests.yml -->\n\n # ⚠️ Action required \n\n :wave: Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the [integration workflow](https://gh.io/testing_primer_at_dotcom). Or, apply the `integration-tests: skipped manually` label to skip these checks.' | ||
| body: '<!-- recommend-integration-tests.yml -->\n\n # ⚠️ Action required \n\n :wave: Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the [integration workflow](https://github.com/github/github-ui/actions/workflows/primer-react-pr-test.yml). Check the [integration testing docs](https://gh.io/testing_primer_at_dotcom) for step-by-step instructions. Or, apply the `integration-tests: skipped manually` label to skip these checks.' | ||
| }) |
There was a problem hiding this comment.
The PR comment body string is duplicated across branches and is getting long; this makes future edits error-prone (easy for the two messages to drift). Consider extracting a shared constant/template (e.g., base message + first-sentence variant) and reuse it for both createComment calls.
This issue also appears on line 68 of the same file.
Closes #
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist