Skip to content

Add direct link to integration workflow in PR comments#7637

Open
liuliu-dev wants to merge 1 commit intomainfrom
liuliu/add-direct-link-to-integration-workflow
Open

Add direct link to integration workflow in PR comments#7637
liuliu-dev wants to merge 1 commit intomainfrom
liuliu/add-direct-link-to-integration-workflow

Conversation

@liuliu-dev
Copy link
Contributor

Closes #

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@liuliu-dev liuliu-dev added the skip changeset This change does not need a changelog label Mar 6, 2026
@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2026

⚠️ No Changeset found

Latest commit: 83831d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@liuliu-dev liuliu-dev marked this pull request as ready for review March 6, 2026 19:46
@liuliu-dev liuliu-dev requested a review from a team as a code owner March 6, 2026 19:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Action that recommends integration testing so its PR comment includes a direct link to the github/github-ui integration workflow, while still linking to the existing step-by-step docs.

Changes:

  • Replace the “integration workflow” link in the bot comment with a direct link to the github/github-ui Actions workflow.
  • Add an explicit link to the integration testing documentation alongside the workflow link (in both comment variants).
Comments suppressed due to low confidence (1)

.github/workflows/recommend-integration-tests.yml:70

  • Same duplication issue as above: this second createComment body repeats the full message. Extracting a shared constant/template for the comment text would reduce maintenance cost and ensure both branches stay in sync.
                ...issue,
                body: '<!-- recommend-integration-tests.yml -->\n\n # ⚠️ Action required \n\n :wave: Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the [integration workflow](https://github.com/github/github-ui/actions/workflows/primer-react-pr-test.yml). Check the [integration testing docs](https://gh.io/testing_primer_at_dotcom) for step-by-step instructions. Or, apply the `integration-tests: skipped manually` label to skip these checks.'
              })

Comment on lines 60 to 62
...issue,
body: '<!-- recommend-integration-tests.yml -->\n\n # ⚠️ Action required \n\n :wave: Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the [integration workflow](https://gh.io/testing_primer_at_dotcom). Or, apply the `integration-tests: skipped manually` label to skip these checks.'
body: '<!-- recommend-integration-tests.yml -->\n\n # ⚠️ Action required \n\n :wave: Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the [integration workflow](https://github.com/github/github-ui/actions/workflows/primer-react-pr-test.yml). Check the [integration testing docs](https://gh.io/testing_primer_at_dotcom) for step-by-step instructions. Or, apply the `integration-tests: skipped manually` label to skip these checks.'
})
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR comment body string is duplicated across branches and is getting long; this makes future edits error-prone (easy for the two messages to drift). Consider extracting a shared constant/template (e.g., base message + first-sentence variant) and reuse it for both createComment calls.

This issue also appears on line 68 of the same file.

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@iansan5653 iansan5653 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@liuliu-dev liuliu-dev added the integration-tests: skipped manually Changes in this PR do not require an integration test label Mar 6, 2026
@liuliu-dev liuliu-dev enabled auto-merge March 6, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants