Conversation
|
@davisagli thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
sneridagh
left a comment
There was a problem hiding this comment.
LGTM!!
no more plaintext key needed, right? I wonder if we could deprecate it too from Volto...
Now I have a doubt! Didn't we never have indexers for other blocks? for example, teasers?
I guess we could update the slate block indexer to collect text the same way.
It seems we do not. In the case of teasers, it's hard to say what is the right thing to do: including the teaser title in the searchable text could make it harder to find the actual page that is teased, and it would not necessarily be up to date when the teaser is dynamic. btw, I realized there is one more thing I need to do: add an IBlockVisitor that can find sub-blocks inside a plate value. |
Fixes #1998
url)📚 Documentation preview 📚: https://plonerestapi--2015.org.readthedocs.build/