Skip to content

Add backend support for plate block#2015

Merged
davisagli merged 8 commits intomainfrom
somersault
Apr 13, 2026
Merged

Add backend support for plate block#2015
davisagli merged 8 commits intomainfrom
somersault

Conversation

@davisagli
Copy link
Copy Markdown
Member

@davisagli davisagli commented Apr 9, 2026

Fixes #1998

  • extract text for indexing
  • find links for linkintegrity
  • add tests to show resolveuid transforms work (they were already working because we have generic support for any field named url)
  • add IBlockVisitor to find sub-blocks inside a plate value

📚 Documentation preview 📚: https://plonerestapi--2015.org.readthedocs.build/

@davisagli davisagli requested a review from sneridagh April 9, 2026 22:06
@mister-roboto
Copy link
Copy Markdown

@davisagli thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@davisagli davisagli changed the title [WIP] Add backend support for plate block Add backend support for plate block Apr 9, 2026
@davisagli davisagli marked this pull request as ready for review April 9, 2026 22:48
@davisagli
Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

Copy link
Copy Markdown
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

no more plaintext key needed, right? I wonder if we could deprecate it too from Volto...

Now I have a doubt! Didn't we never have indexers for other blocks? for example, teasers?

@davisagli
Copy link
Copy Markdown
Member Author

no more plaintext key needed, right? I wonder if we could deprecate it too from Volto...

I guess we could update the slate block indexer to collect text the same way.

Now I have a doubt! Didn't we never have indexers for other blocks? for example, teasers?

It seems we do not. In the case of teasers, it's hard to say what is the right thing to do: including the teaser title in the searchable text could make it harder to find the actual page that is teased, and it would not necessarily be up to date when the teaser is dynamic.

btw, I realized there is one more thing I need to do: add an IBlockVisitor that can find sub-blocks inside a plate value.

@davisagli davisagli merged commit be7afaf into main Apr 13, 2026
16 of 18 checks passed
@davisagli davisagli deleted the somersault branch April 13, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backend support for Plate block

3 participants