Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevent excessive buffer allocation in stream marshal/unmarshal #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
prevent excessive buffer allocation in stream marshal/unmarshal #166
Changes from all commits
e97de62File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types High
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The FastSSZ delegation guard uses
sourceType.Sizeto decide whether to callMarshalSSZTo, but for dynamic containersTypeDescriptor.Sizeis typically0(unknown), which will always pass the<= MaxEncodeBufferSize()check and still trigger a full temporary buffer allocation on stream encoders (the issue this PR is trying to prevent). Consider using the fastsszSizeSSZ()result (with an overflow check) whensourceType.Size == 0(and encoder is non-seekable), or conservatively skipping delegation when the size is unknown.Check failure
Code scanning / CodeQL
Incorrect conversion between integer types High
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block converts
sourceType.Size(uint32) tointwhen comparing againstMaxEncodeBufferSize()without guarding against platform overflow. On 32-bit platforms (or very large size hints),int(sourceType.Size)can wrap and incorrectly allow delegation. Consider checkingsourceType.Size > math.MaxIntfirst (returningErrPlatformOverflowFn) or performing comparisons inint64/uint64safely.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new
MaxEncodeBufferSize()-based delegation behavior (skipping buffer-based marshal methods on stream encoders when the payload is large) doesn’t appear to be covered by tests. Adding a unit test that asserts large values do not invokeFastsszMarshaler/DynamicMarshaleronStreamEncoder(but still do onBufferEncoder) would help prevent regressions.Check failure
Code scanning / CodeQL
Incorrect conversion between integer types High
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same potential
uint32->intoverflow issue here:int(sourceType.Size)is used implicitly viaint(...) <= MaxEncodeBufferSize()in the condition. To avoid incorrect delegation decisions on platforms whereintis smaller thanuint32, add an explicit overflow guard (or compare in a wider type) before converting.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.