fix(ci): compare new benchmarks with base#165
Open
Sahil-4555 wants to merge 3 commits intopk910:masterfrom
Open
fix(ci): compare new benchmarks with base#165Sahil-4555 wants to merge 3 commits intopk910:masterfrom
Sahil-4555 wants to merge 3 commits intopk910:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
=======================================
Coverage 95.75% 95.75%
=======================================
Files 47 47
Lines 10921 10921
=======================================
Hits 10457 10457
Misses 290 290
Partials 174 174
🚀 New features to boost your workflow:
|
Benchmark ResultsLibrary BenchmarksPerformance Benchmarks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
The benchmark bot was not comparing the new
NodeProveMulti/...andNodeProve/...benchmarks with base. The base run was using the older benchmark test harness, so base-lib.txt did not contain those benchmark names.Fix:
This PR updates the benchmark workflow to sync benchmark test files from the PR checkout into the base checkout before running base benchmarks, only when those files differ. This lets the base run include the same benchmark names, so the bot can show proper comparisons without doing unnecessary sync work.