Add BYOC support to create_index, describe_index, list_indexes#482
Merged
jhamon merged 1 commit intorelease-candidate/2025-04from May 15, 2025
Merged
Add BYOC support to create_index, describe_index, list_indexes#482jhamon merged 1 commit intorelease-candidate/2025-04from
create_index, describe_index, list_indexes#482jhamon merged 1 commit intorelease-candidate/2025-04from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
BYOC requires a new type of spec object,
ByocSpec.Solution
ByocSpectype:Pinecone#create_indexPineconeAsyncio#create_indexpc.db.index.create)IndexResource#createAsyncioIndexResource#createType of Change
Test Plan
IndexModelobject. This is important since I'm currently not set up to do a full integration test of the feature.