Skip to content

Add BYOC support to create_index, describe_index, list_indexes#482

Merged
jhamon merged 1 commit intorelease-candidate/2025-04from
jhamon/byoc
May 15, 2025
Merged

Add BYOC support to create_index, describe_index, list_indexes#482
jhamon merged 1 commit intorelease-candidate/2025-04from
jhamon/byoc

Conversation

@jhamon
Copy link
Copy Markdown
Collaborator

@jhamon jhamon commented May 14, 2025

Problem

BYOC requires a new type of spec object, ByocSpec.

Solution

  • Update legacy-style methods to accept new ByocSpec type:
    • Pinecone#create_index
    • PineconeAsyncio#create_index
  • Update resource classes (accessed from pc.db.index.create)
    • IndexResource#create
    • AsyncioIndexResource#create
  • Update interfaces used for docgen

Type of Change

  • New feature (non-breaking change which adds functionality)

Test Plan

  • Added a new unit test to ensure the client can properly deserialize API responses (e.g. from describe, list) that include the new byoc spec type into the IndexModel object. This is important since I'm currently not set up to do a full integration test of the feature.

@jhamon jhamon changed the base branch from main to release-candidate/2025-04 May 14, 2025 09:51
@jhamon jhamon marked this pull request as ready for review May 14, 2025 09:51
@jhamon jhamon requested a review from austin-denoble May 14, 2025 09:51
@jhamon jhamon merged commit f5c19e9 into release-candidate/2025-04 May 15, 2025
70 checks passed
@jhamon jhamon deleted the jhamon/byoc branch May 15, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant