Use lazy loading in error decorator, debugging config#481
Merged
jhamon merged 2 commits intorelease-candidate/2025-04from May 15, 2025
Merged
Use lazy loading in error decorator, debugging config#481jhamon merged 2 commits intorelease-candidate/2025-04from
jhamon merged 2 commits intorelease-candidate/2025-04from
Conversation
8551a79 to
663a819
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We want to continue improving our import and initialization times.
Solution
@validate_and_convert_errorsdecorator to use lazy-loading ofurllib3. We only need to load urllib3 in this decorator at the moment an exception has occurred.pinecone.config.openapi_configuration.pyto avoid loading thehttpmodule unless enabling debug logging. The default http log level is already 0 (disabled) so there's no need to set it in the default case.Perf testing
Comparing the importtime results before and after this change shows a reduction from 101ms to 65ms, a savings of 36ms which is about 36%.