Convert more zend_parse_parameters_none() to fast ZPP#21330
Merged
alexandre-daubois merged 1 commit intophp:masterfrom Mar 4, 2026
Merged
Convert more zend_parse_parameters_none() to fast ZPP#21330alexandre-daubois merged 1 commit intophp:masterfrom
alexandre-daubois merged 1 commit intophp:masterfrom
Conversation
alexandre-daubois
requested review from
Girgias,
NattyNarwhal,
SakiTakamachi,
alexdowad,
bukka,
dstogov,
kamil-tekiela,
ndossche and
youkidearitai
as code owners
github-actions
bot
added
SAPI: fpm
Extension: openssl
Extension: com_dotnet
Extension: dba
Extension: dom
Extension: enchant
Extension: filter
Extension: hash
Extension: mbstring
Extension: mysqli
Extension: odbc
Extension: opcache
Extension: pdo_firebird
Extension: readline
Extension: session
Extension: sqlite3
Extension: standard
Extension: xmlwriter
Extension: xsl
Extension: zlib
labels
github-actions
bot
added
SAPI: apache2handler
SAPI: cgi
SAPI: cli
SAPI: litespeed
SAPI: phpdbg
labels
iluuu1994
approved these changes
Mar 3, 2026
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
Seems ok to me, if others are ok with the code churn.
ndossche
approved these changes
Mar 3, 2026
Girgias
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New round of converting to fast ZPP, following already merged PRs. There are some remaining but I prefer to avoid a too big diff.