Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix Windows release asset handling by standardizing the Windows ZIP asset name and updating both install scripts and CI to use/upload that standardized asset, ensuring the “latest” Windows download URL is stable.
Changes:
- Update
install.shandinstall.ps1to download a fixed Windows asset name (frankenphp-windows-x86_64.zip) instead of querying the GitHub Releases API. - Adjust the Windows GitHub Actions workflow to build/upload a consistently named Windows ZIP asset and to better determine the release tag for uploads.
- Update the docs deployment workflow triggers to run when the install scripts change.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| install.sh | Hard-codes Windows ZIP asset download URL for install-on-Windows paths. |
| install.ps1 | Removes GitHub API lookup; directly downloads the standardized Windows ZIP asset. |
| .github/workflows/windows.yaml | Standardizes Windows release asset naming and modifies release tag/version selection + upload conditions. |
| .github/workflows/docs.yaml | Triggers docs deployment when install scripts change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.