Skip to content

Add v1.7.0 notes to CHANGELOG.md#91

Open
mason-sharp wants to merge 2 commits intomainfrom
task/prepare-v1.7.0
Open

Add v1.7.0 notes to CHANGELOG.md#91
mason-sharp wants to merge 2 commits intomainfrom
task/prepare-v1.7.0

Conversation

@mason-sharp
Copy link
Member

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1b8ef19b-c5e0-4a60-873e-ab98678d77fb

📥 Commits

Reviewing files that changed from the base of the PR and between 138aaf9 and 3d90881.

📒 Files selected for processing (1)
  • docs/CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/CHANGELOG.md

📝 Walkthrough

Walkthrough

Updates CHANGELOG for v1.7.0 and implements runtime SIGHUP config reloads, a table-repair --preserve-origin option, CLI migration to urfave/cli v3, thread-safe config snapshotting and atomic mTLS validator replacement, plus several bug fixes and tests.

Changes

Cohort / File(s) Summary
Release notes
docs/CHANGELOG.md
Add v1.7.0 entry describing table-repair --preserve-origin, SIGHUP runtime config reload, CLI migration, thread-safe config reads, atomic mTLS validator swap, and listed bug fixes.
CLI / commands
cmd/ace/..., cmd/table-repair/...
Migrate CLI usage to urfave/cli v3 to permit interspersed flags; add --preserve-origin option to table-repair command and related CLI wiring.
Config & reload
internal/config/..., internal/sighup/..., cmd/ace/start.go
Implement SIGHUP-triggered reload across long-running modes; per-request/task/stream snapshotting for thread-safe config reads; scheduler waits for in-flight jobs before swap, API server reloads immediately.
mTLS / security
internal/api/server/..., internal/tls/...
Replace mTLS certificate validator atomically (use of atomic.Pointer) so request-path reads are lock-free and validator is swap-on-reload, including CRL and allowed-CN handling.
Replication / repair logic
pkg/replication/..., pkg/table_repair/...
Preserve replication origin metadata in repair: group upserts by (origin, timestamp) into separate transactions and commit deletes in preceding transaction to avoid rejoin conflicts; stop clearing origin metadata before WAL commit.
Schema & diffs
pkg/schema/..., cmd/repset-diff/...
Fix repset-diff behavior and tests; make schema-diff --skip-tables accept schema-qualified names with proper validation and matching (strip schema prefix).
Replication origin lookup
pkg/replication/origin_lookup.go, pkg/db/...
Replace ineffective LIKE-based LSN lookup with proper joins through spock.subscription and spock.node to correctly resolve replication origin LSNs.
Scheduler / robustness
internal/scheduler/...
Handle unexpected scheduler exit during SIGHUP reload loop to avoid crashes; add related tests.

Poem

🐰 nose twitching in the server room

New hops of code, a soft SIGHUP breeze,
Origins kept safe through repairs with ease,
Configs swap clean while jobs finish their run,
Bugs nibbled down — now the meadow’s more fun!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relevance to the changeset. Add a brief description explaining the purpose of the v1.7.0 changelog entries and any context for reviewers.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding v1.7.0 release notes to CHANGELOG.md, which matches the changeset exactly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch task/prepare-v1.7.0
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/CHANGELOG.md`:
- Line 5: The changelog entry header "## [v1.7.0] - 2026-03-20" uses a future
release date; change that header to use an unreleased marker (e.g., "##
[Unreleased]" or "## [v1.7.0] - Unreleased") while preparing the PR and then
stamp the exact date into the "## [v1.7.0] - YYYY-MM-DD" header (replacing the
unreleased marker) at release/tag time so the published date is accurate.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8fdffd37-3ba3-4c85-83e1-4cb742703b0b

📥 Commits

Reviewing files that changed from the base of the PR and between 0a2edff and 138aaf9.

📒 Files selected for processing (1)
  • docs/CHANGELOG.md


All notable changes to ACE will be captured in this document. This project follows semantic versioning; the latest changes appear first.

## [v1.7.0] - 2026-03-20
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Use an unreleased marker or set the final release date at tag time.

2026-03-20 is a future date relative to this open PR (2026-03-18), so this may be misleading if release timing changes. Consider using ## [Unreleased] during prep, then stamping the exact date when the release is cut.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/CHANGELOG.md` at line 5, The changelog entry header "## [v1.7.0] -
2026-03-20" uses a future release date; change that header to use an unreleased
marker (e.g., "## [Unreleased]" or "## [v1.7.0] - Unreleased") while preparing
the PR and then stamp the exact date into the "## [v1.7.0] - YYYY-MM-DD" header
(replacing the unreleased marker) at release/tag time so the published date is
accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants