Handle empty/incomplete gcloud config file gracefully#192
Open
mattwynne wants to merge 1 commit intopeburrows:masterfrom
Open
Handle empty/incomplete gcloud config file gracefully#192mattwynne wants to merge 1 commit intopeburrows:masterfrom
mattwynne wants to merge 1 commit intopeburrows:masterfrom
Conversation
When ~/.config/gcloud/configurations/config_default exists but is empty or missing the [core] section, return nil with a warning log instead of crashing. This lets the credential fallback chain continue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
~/.config/gcloud/configurations/config_defaultexists but is empty or missing the required[core]section (e.g. after runninggcloud auth liston a fresh install),get_configuration_data/1crashes trying to access keys on a nil/empty map. This crashes the GenServer with aCaseClauseErrorand prevents any fallback credential sources from being tried.This change makes
get_configuration_data/1pattern-match for the expected structure and returnnilwhen it's not present, with a warning log that tells the user how to fix it. This lets the credential fallback chain infrom_gcloud_adc/1continue to metadata or other sources.Before
After
And Goth continues to try other credential sources.
Licensing:
This contribution is made by employees of Mechanical Orchard, Inc. under the terms of the project's license.