Feature/mfx is lcls2

[silkenelson]

changes for RIXS pedestals in takepeds
determine LCLS1 vs LCLS2 experiment
use of the former script in makepeds
makepeds_psana2 also for axis (to be worked on more)
small bug fixes
use of segment number currently needed in deploy step

[KaushikMalapati]

Once you look at all the comments, would you mind running these scripts again and making sure they work?

[tangkong]

There are a lot of comments that defer fixes to different efforts. If we're not going to address them immediately, can we make issues for them so we don't lose track of them?

[KaushikMalapati]

There are a lot of comments that defer fixes to different efforts. If we're not going to address them immediately, can we make issues for them so we don't lose track of them?

I only found two which I made issues for (the function for getting the experiment, and putting check_for_status in a try/except). Were there any others?

[KaushikMalapati]

@silkenelson the trailing whitespace, eof, flake8, and isort jobs are failing. Can you commit the changes for those those? I think we can ignore the shellcheck errors for now.

[ZLLentz]

fwiw I don't think any PR creator is obligated to spend time solving pre-existing problems unrelated to the PR, maybe we can just run ruff/precommit on this afterwards (see the dormant #270)

[KaushikMalapati]

fwiw I don't think any PR creator is obligated to spend time solving pre-existing problems unrelated to the PR, maybe we can just run ruff/precommit on this afterwards (see the dormant #270)

Makes sense, I was assuming they were introduced here.

[ZLLentz]

I guess it's possible some of them are, I didn't look so closely but I know many of them are not created here

[tangkong]

I only found two which I made issues for (the function for getting the experiment, and putting check_for_status in a try/except). Were there any others?

Maybe two issues was too much for my goldfish memory. Looking through the comments this looks appropriate

[ZLLentz]

I think everything here is good to merge
I do want a couple eyes on #270 so we can auto fix some of the incidentals

[KaushikMalapati]

Doesn't this sys.exit() need to be in the else block so that we don't return if we get the hutch from args.setExp?

[silkenelson]

Shoot, yes!