Skip to content

finance feature#273

Open
kilip wants to merge 8 commits intomainfrom
wip
Open

finance feature#273
kilip wants to merge 8 commits intomainfrom
wip

Conversation

@kilip
Copy link
Copy Markdown
Contributor

@kilip kilip commented Apr 18, 2026

No description provided.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Apr 18, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
domus-cron 87ee882 Commit Preview URL

Branch Preview URL
Apr 18 2026, 04:26 PM

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
domus Ready Ready Preview Apr 18, 2026 4:38pm

kilip added 7 commits April 19, 2026 00:19
- Add unique constraint on (month, year) for financial periods
- Restrict management actions to Treasurer role only
- Implement Premium Hero dashboard and period management UI
- Fix type safety and linting in finance components

Ref: FIN-01
Closes #111
- Refactor CategoryForm to use useDomusForm for architectural consistency
- Stabilize E2E tests by adding specific toast IDs and improving POM
- Update Indonesian translations for consistent labels and actions
- Pass all quality checks (format, lint, typecheck, e2e)

Issue: #112
- Add unique constraint to transaction_categories table to stabilize tests
- Implement DateField, ReceiptUploadField and register in DomusForm context
- Create TransactionCreatePage with reactive category selection via form.Subscribe
- Build server actions for transaction creation and Google Drive receipt upload
- Add 'Catat Transaksi' navigation to FinancialPeriodList UI
- Implement robust E2E test suite in serial mode for transaction recording

Closes #113
- add yearly report table with total income/expense per month
- add monthly report collapsible with per-category transaction details
- implement transaction grouping logic in core service
- fix type safety and linting issues in finance modules

Closes #114
- Added runtime validation with Zod in createTransactionAction to handle form data coercion.
- Updated TransactionEntity to use z.coerce for amount and date fields.
- Relaxed UUID validation from z.uuidv7() to z.uuid() for compatibility with Better Auth IDs.
- Fixed translation key mismatch in FinancePage POM (dicatat vs disimpan).
- Added guard for dynamic translation key in FinancialPeriodList to prevent 'undefined' warnings.
- Cleaned up verbose debug logging in repository and service layers.
Ref #188

- Refactored AttachmentUpload to use standard react state, dropping react-hook-form
- Fixed typechecking error in AttachmentList by using buttonVariants with standard anchor tag
- Fixed server actions to properly handle AuthContext and updated file usage
- Added basic error handling to AttachmentUpload callbacks
- Successfully passed typecheck, lint, and formatting tests
… tests

- Implement organizational term management (ST-05) core logic and UI.
- Stabilize term-management E2E tests by refining sync logic for Google Drive uploads.
- Fix Playwright visibility issues caused by CSS truncate class in attachment items.
- Improve POM with robust wait strategies for server-side revalidation.
- Closes #188
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 18, 2026

Codecov Report

❌ Patch coverage is 34.22562% with 344 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.72%. Comparing base (6ff86d5) to head (87ee882).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
apps/dash/src/pages/org/actions/term.ts 0.00% 59 Missing ⚠️
...dash/src/pages/finance/actions/financial-period.ts 0.00% 56 Missing ⚠️
.../src/pages/finance/actions/transaction-category.ts 0.00% 44 Missing ⚠️
apps/dash/src/pages/finance/actions/transaction.ts 0.00% 40 Missing ⚠️
...dash/src/features/attachment/actions/attachment.ts 0.00% 30 Missing ⚠️
apps/dash/src/pages/finance/actions/report.ts 0.00% 27 Missing ⚠️
...s/dash/src/pages/finance/actions/upload-receipt.ts 0.00% 18 Missing ⚠️
packages/core/src/service/transaction-category.ts 79.16% 15 Missing ⚠️
packages/core/src/service/transaction.ts 77.94% 15 Missing ⚠️
apps/dash/src/shared/core/service.ts 0.00% 7 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
- Coverage   54.06%   51.72%   -2.34%     
==========================================
  Files         128      139      +11     
  Lines        4056     4541     +485     
  Branches      831      938     +107     
==========================================
+ Hits         2193     2349     +156     
- Misses       1860     2189     +329     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant