Adds find_package(Catch2) to test_nodes CMakeLists#486
Closed
Adds find_package(Catch2) to test_nodes CMakeLists#486
Conversation
Collaborator
Author
|
needs more elaboration |
Owner
|
This is maybe not very clear from the name (external), maybe we should move the fings outside the external directory |
Collaborator
Author
|
The problem is that I have Catch2 3.6.0 installed, and the configuration won't work due to the different version. I propose we revert the And when the system package is found, there should be a Is there a reason you removed the explicit Catch2 version from find_package? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
In case you have Catch2 installed and the correct system variable for
Catch2_DIR, thetest_nodeslib won't find the Catch2 package without the explicit directive to see it.This PR includes
find_package(Catch2)to test_nodes CMakeLists.txt to fix that.And it also adds instructions in README.txt, to create the Catch2_DIR system variable.
Testing
Breaking changes?
No
Related issue
None.