Use a fixed margin for bounding rectangle rather than a ratio of node size#470
Merged
paceholder merged 2 commits intopaceholder:masterfrom Jun 9, 2025
Merged
Conversation
Malcohol
changed the title
Jan-Felix-Langenbach-casaGeo
added a commit
to casaGeo-Data-Services-GmbH/nodeeditor
that referenced
this pull request
Sep 7, 2025
The issue was fixed upstream (see paceholder#470) in commit 3ed0391. This reverts commit 551b609.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current ratio-based calculation for bounding rectangle leads to a weird situation where the mouse does not necessarily select the nearest node. In the screenshot, the mouse is selecting the top node rather than the nearer node on the left:
This PR fixes the problem using a fixed value (twice the port spacing) as the extra margin. Since the required information is not available in the AbstractNodeGeometry, the boundingRect method has been made pure virtual and implementations are provided in DefaultHorizontalNodeGeometry and DefaultVerticalNodeGeometry.