don't always use default silo when selecting default pool#3191
Merged
david-crespo merged 3 commits intomainfrom Apr 20, 2026
Merged
don't always use default silo when selecting default pool#3191david-crespo merged 3 commits intomainfrom
david-crespo merged 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just pulls a small fix to the mock API out of #3033, which I'll be closing shortly. I don't expect this to change much in day-to-day usage of the mock API.
In short, when auto-selecting an IP Pool, the mock API currently selects the default pool from the default silo, regardless of what silo you're actually interacting with. To be clear, this is just an issue in the mock backend we use for local development / testing of the console app, not an underlying issue with Omicron.
The fix here involves passing in the actual silo the project belongs to, instead of just going with the default silo's default pool.