Skip to content

Fix dead space in combobox dropdown#3186

Merged
david-crespo merged 1 commit intomainfrom
dont_dead_open_inside
Apr 20, 2026
Merged

Fix dead space in combobox dropdown#3186
david-crespo merged 1 commit intomainfrom
dont_dead_open_inside

Conversation

@charliepark
Copy link
Copy Markdown
Contributor

@charliepark charliepark commented Apr 17, 2026

This patches up the combobox by adding a pseudo element before the button, and then makes the button full-height.
Have checked it across browsers and all seems well.
Screen Recording 2026-04-17 at 7 52 43 PM mov

It was looking a little faint to me, but here's a quick comparison with the current style:

current:
Screenshot 2026-04-17 at 7 55 56 PM

with pseudo element:
Screenshot 2026-04-17 at 7 56 29 PM

Closes #3185

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
console Ready Ready Preview Apr 17, 2026 5:58pm

Request Review

@charliepark
Copy link
Copy Markdown
Contributor Author

This is with stroke-default, if we feel like this is better:
Screenshot 2026-04-17 at 8 09 44 PM

Copy link
Copy Markdown
Collaborator

@david-crespo david-crespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks! I like the line better dim. It's true that when you pay attention to it, it looks a little weird, but when you're just glancing at the button casually, it gives the button a nice boundary without calling attention to itself.

@david-crespo david-crespo merged commit f25398d into main Apr 20, 2026
7 checks passed
@david-crespo david-crespo deleted the dont_dead_open_inside branch April 20, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dead space around combobox button

2 participants