Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
access-token-pages
branch
from
47bba62 to
d66310f
Compare
david-crespo
force-pushed
the
access-token-pages
branch
from
d66310f to
1efed50
Compare
Contributor
|
We're best leaving out the access setting part. In part because of the permissions issue, but also that design will change, whereas the table is likely to stay as it is. |
david-crespo
force-pushed
the
access-token-pages
branch
from
1efed50 to
1dbd08c
Compare
david-crespo
changed the title
david-crespo
commented
Jun 3, 2025
| </NavLinkItem> | ||
| <NavLinkItem to={pb.siloAccess()}> | ||
| <Access16Icon /> Access | ||
| <Access16Icon /> Silo Access |
Collaborator
Author
There was a problem hiding this comment.
I kept these renames from the silo access page changes because they're easy wins.
david-crespo
force-pushed
the
access-token-pages
branch
from
98b71d8 to
5f203b3
Compare
Collaborator
Author
|
Not my favorite docs popover copy, but I felt it was important to be clear that you can't create tokens from this page, as I think the user would expect that you can. I don't see why we can't add that in the future. 
|
charliepark
approved these changes
Jun 3, 2025
1 task
Collaborator
Author
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jun 4, 2025
oxidecomputer/console@46e244f...e891f96 * [e891f968](oxidecomputer/console@e891f968) oxidecomputer/console#2833 * [f2584554](oxidecomputer/console@f2584554) oxidecomputer/console#2832 * [a186ae6f](oxidecomputer/console@a186ae6f) oxidecomputer/console#2825 * [a480ca7f](oxidecomputer/console@a480ca7f) tools: api-diff: switch from difftastic to delta * [ad05de96](oxidecomputer/console@ad05de96) tools: api-diff comment fix * [77d5849d](oxidecomputer/console@77d5849d) tools: fix api-diff to get more precise PR base commit * [f8c05f20](oxidecomputer/console@f8c05f20) oxidecomputer/console#2808 * [50a84bc1](oxidecomputer/console@50a84bc1) bump omicron to latest main for webhook secret timestamp
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Jun 4, 2025
oxidecomputer/console@46e244f...e891f96 * [e891f968](oxidecomputer/console@e891f968) oxidecomputer/console#2833 * [f2584554](oxidecomputer/console@f2584554) oxidecomputer/console#2832 * [a186ae6f](oxidecomputer/console@a186ae6f) oxidecomputer/console#2825 * [a480ca7f](oxidecomputer/console@a480ca7f) tools: api-diff: switch from difftastic to delta * [ad05de96](oxidecomputer/console@ad05de96) tools: api-diff comment fix * [77d5849d](oxidecomputer/console@77d5849d) tools: fix api-diff to get more precise PR base commit * [f8c05f20](oxidecomputer/console@f8c05f20) oxidecomputer/console#2808 * [50a84bc1](oxidecomputer/console@50a84bc1) bump omicron to latest main for webhook secret timestamp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on top of oxidecomputer/omicron#8231, so that needs to merge and then we need to bump the API here to a main commit.
My tokens page is very straightforward — all you can do is list and delete, and those operations are extremely simple.
Extra messaging in confirmation explaining what happens when you kill a token:
Tooltip on
idcolumn explaining that it is not the token itself.Moved to #2834
Access page is a little harder — any silo viewer can see this value, and that's basically everyone, but only silo admins can edit it. We don't have a good way to detect who is a silo admin. For fleet viewer, we hit an endpoint and see if it 403s. I was thinking maybe we should addfleet_roleandsilo_rolefields to the/v1/meresponse — that would make this easy. Not sure if there's good stopgap for v15, or maybe we should just take this page out and leave it to the CLI for now.