Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benjaminleonard
commented
May 16, 2025
| }) => { | ||
| return ( | ||
| <div className="mb-12 flex min-w-min flex-col gap-3 lg+:flex-row"> | ||
| <div className="1000:flex-row mb-12 flex min-w-min flex-col gap-3"> |
Contributor
Author
There was a problem hiding this comment.
These breakpoints I've added to the design system, previously we had a different style for this syntax each time. The width syntax here I find much easier since I don't have to remember how wide sm is.
Contributor
Author
|
@david-crespo Let me know if it's worth pushing this to fix all the remaining bits or leave for later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From oxidecomputer/design-system#133
We can hold on this and revisit until we have fewer PRs since it touches so many files, I just wanted to find any issues with the design system upgrade first. It did surface a couple small issues which I've fixed.
The lack of a z-index utility is a little clunky here. And still a couple things to fix. There's some strange table behaviour and I think I need to check the complex variants are behaving as they should.