Skip to content

fix: make profiler configurable and disable it by default in non-debug mode #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nyholm merged 1 commit into from
Apr 13, 2026
Merged

fix: make profiler configurable and disable it by default in non-debug mode #1243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,7 @@ private function profilerSection(): ArrayNodeDefinition

// @phpstan-ignore-next-line
$node
->{$this->debug ? 'canBeDisabled' : 'canBeEnabled'}()
->addDefaultsIfNotSet()
->children()
->scalarNode('query_match')->defaultNull()->end()
Expand Down
13 changes: 10 additions & 3 deletions src/DependencyInjection/OverblogGraphQLExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ final class OverblogGraphQLExtension extends Extension
{
public function load(array $configs, ContainerBuilder $container): void
{
$this->loadConfigFiles($container);
$configuration = $this->getConfiguration($configs, $container);
$config = $this->processConfiguration($configuration, $configs);

$this->loadConfigFiles($config, $container);
$this->setBatchingMethod($config, $container);
$this->setServicesAliases($config, $container);
$this->setSchemaBuilderArguments($config, $container);
Expand Down Expand Up @@ -75,7 +75,7 @@ public function getConfiguration(array $config, ContainerBuilder $container): Co
);
}

private function loadConfigFiles(ContainerBuilder $container): void
private function loadConfigFiles(array $config, ContainerBuilder $container): void
{
$loader = new YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
$loader->load('services.yaml');
Expand All @@ -86,7 +86,10 @@ private function loadConfigFiles(ContainerBuilder $container): void
$loader->load('expression_language_functions.yaml');
$loader->load('definition_config_processors.yaml');
$loader->load('aliases.yaml');
$loader->load('profiler.yaml');

if ($config['profiler']['enabled']) {
$loader->load('profiler.yaml');
}
}

private function registerForAutoconfiguration(ContainerBuilder $container): void
Expand Down Expand Up @@ -143,6 +146,10 @@ private function setDefinitionParameters(array $config, ContainerBuilder $contai

private function setProfilerParameters(array $config, ContainerBuilder $container): void
{
if (!$config['profiler']['enabled']) {
return;
}

$container->setParameter($this->getAlias().'.profiler.query_match', $config['profiler']['query_match']);
}

Expand Down
Loading