Skip to content

Adjusting Polyglot Sampler to GR-54300#656

Open
JaroslavTulach wants to merge 1 commit intooracle:masterfrom
JaroslavTulach:PolyglotSamplerModuleMode
Open

Adjusting Polyglot Sampler to GR-54300#656
JaroslavTulach wants to merge 1 commit intooracle:masterfrom
JaroslavTulach:PolyglotSamplerModuleMode

Conversation

@JaroslavTulach
Copy link
Contributor

@JaroslavTulach JaroslavTulach commented Mar 7, 2026

  • There is a problem initializing VisualVM 2.2 Polyglot Sampler with Truffle 25.0.0 when the application is running in module path mode.
  • this is caused by GR-54300 changes that modified the ENGINES field from Map to Set which remained unnoticed for a while

Reproduce

  • I've created a sample project https://github.com/jtulach/graaljs/tree/GraalJsDemo
  • when executed in module path mode: mvn -Pmodulepath package exec:exec the VisualVM Polyglot Sampler can't connect
    • everything works in classpath mode
    • everything also works when one --add-opens access for the access to findActiveEngines method...

Fix

This change modifies the Unsafe code of the stagent to be ready for Map as well as Set value being returned from the field.

CCing @tzezula

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 7, 2026
@thurka
Copy link
Member

thurka commented Mar 14, 2026

Could you please file it as a bug? Thanks.

@JaroslavTulach
Copy link
Contributor Author

Could you please file it as a bug? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants