Skip to content

fix: suggest true/false completions for BOOLEAN params in interactive mode#1057

Open
jja6312 wants to merge 1 commit intooracle:masterfrom
jja6312:1056-bool-param-interactive-completion
Open

fix: suggest true/false completions for BOOLEAN params in interactive mode#1057
jja6312 wants to merge 1 commit intooracle:masterfrom
jja6312:1056-bool-param-interactive-completion

Conversation

@jja6312
Copy link
Copy Markdown

@jja6312 jja6312 commented Mar 29, 2026

Summary

Fixes #1056

In interactive mode (oci -i), BOOLEAN parameters had no completion
suggestions when pressing Tab. This caused an error in the bottom toolbar
because the completer fell through to the resource-fetching path, which
is incorrect for BOOLEAN types.

Changes

  • Added check_param_is_bool() helper in oci_shell_completer.py,
    following the same pattern as the existing check_param_is_flag()
  • Added a click.BOOL branch in get_completions() that returns
    true and false as completions

How to Validate

  1. Start interactive mode: oci -i
  2. Type and press Tab after a BOOLEAN parameter:
    oci iam compartment list --compartment-id-in-subtree <TAB>
  3. true and false now appear as suggestions

Before

image

After

image

… mode

Signed-off-by: jja6312 <jajeong@wizbase.co.kr>
@oracle-contributor-agreement
Copy link
Copy Markdown

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Mar 29, 2026
@oracle-contributor-agreement
Copy link
Copy Markdown

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interactive mode: BOOLEAN parameters have no completion suggestions

1 participant