Skip to content

AB#277632 - Overlay messaging#89

Open
vvoicehovics wants to merge 28 commits intomasterfrom
277632-overlay-messaging
Open

AB#277632 - Overlay messaging#89
vvoicehovics wants to merge 28 commits intomasterfrom
277632-overlay-messaging

Conversation

@vvoicehovics
Copy link
Copy Markdown
Contributor

@vvoicehovics vvoicehovics commented Mar 29, 2026

Description of Changes

https://mobius.visualstudio.com/Backstage/_workitems/edit/277632

New Overlay Messaging channel with following API

- OptimoveConfig.Builder........enableOverlayMessaging(sessionLengtHours: = 1h)
- OverlayMessaging.getInstance().resetSession();
- OverlayMessaging.getInstance().setInterceptor(callback)
XRecorder_20260401_03.mp4

Can coexist with in-app

Breaking Changes

  • None

Release Checklist

Prepare:

  • Detail any breaking changes. Breaking changes require a new major version number, and a migration guide in wiki / README.md

Bump versions in:

  • CHANGELOG.md
  • gradle.properties
  • add links to newly created wiki pages to readme
  • Update major version numbers in wiki (basic integration + push guides)

Integration tests

T&T Only

  • Init SDK with only optimove credentials
  • Associate customer
  • Associate email
  • Track events

Mobile Only

  • Init SDK with all credentials
  • Track events
  • Associate customer (verify both backends)
  • Register for push
  • Opt-in for In-App
  • Send test push
  • Send test In-App
  • Receive / trigger deep link handler (In-App/Push)
  • Receive / trigger the content extension, render image and action buttons for push
  • Verify push opened handler

Deferred Deep Links

  • With app installed, trigger deep link handler
  • With app uninstalled, follow deep link, install test bundle, verify deep link read from Clipboard, trigger deep link handler

Combined

  • Track event for T&T, verify push received
  • Trigger scheduled campaign, verify push received
  • Trigger scheduled campaign, verify In-App received

Release Procedure

  • Squash and merge dev to master
  • Delete branch once merged

@wiz-190b289812
Copy link
Copy Markdown
Contributor

wiz-190b289812 Bot commented Mar 29, 2026

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings 7 Medium
Software Management Finding Software Management Findings -
Total 7 Medium

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@vvoicehovics vvoicehovics force-pushed the 277632-overlay-messaging branch from 7f41d4e to 5441f91 Compare March 30, 2026 13:21
@vvoicehovics vvoicehovics changed the title Overlay messaging AB#277632 - Overlay messaging Mar 30, 2026
@vvoicehovics vvoicehovics force-pushed the 277632-overlay-messaging branch from 627387d to ee7d769 Compare April 1, 2026 22:35
Comment thread OptimoveSDK/optimove-sdk/src/main/java/com/optimove/android/OptimoveConfig.java Outdated
@vvoicehovics vvoicehovics force-pushed the 277632-overlay-messaging branch from f1618bc to 50d9b27 Compare April 6, 2026 13:31
@vvoicehovics vvoicehovics force-pushed the 277632-overlay-messaging branch from cfc6237 to b62a511 Compare April 6, 2026 13:46


@UiThread
BaseMessageView(@NonNull Activity currentActivity, boolean manageStatusBarColor) {
Copy link
Copy Markdown
Contributor Author

@vvoicehovics vvoicehovics Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. views set status bar color to black to prevent random color bar from activity show on top of styled in-app (black kind of fits all if i recall rationale). So, color is set, then unset when view closed.
  2. Now as we have overlay + in-app potentially showing simultaneously, their sets-unsets can leave it in incorrect state (e.g. 2nd unset changes it to the 1st set)
  3. dialog also does Theme_Translucent_NoTitleBar_Fullscreen, which in theory should prevent any bar showing at all. This is what i observe in test app, this is what AIs conclude, though this is too specific for them not to get creative.
  4. i cant categorically confirm setting color is not needed on any devices, the repository which had original rationale doesnt exist anymore.

so, the outcome here is to let in-app do what it was doing and the new channel doesnt touch status color until we have issues. I think this is better vs creating complex implementations for phantom problems we maybe had years ago

@graciecooper or you have idea why it's needed? there is related PR from @k-antipochkin here #63

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, I’m happy to leave it as-is for now rather than pre-emptively solving a problem that might not actually be a problem

@vvoicehovics vvoicehovics marked this pull request as ready for review April 7, 2026 12:55
Comment thread CHANGELOG.md
@@ -1,5 +1,9 @@
# Changelog

## 7.13.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i've stolen your version number with a new bugfix ! 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants