Open
Conversation
Contributor
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
7f41d4e to
5441f91
Compare
vvoicehovics
commented
Mar 30, 2026
627387d to
ee7d769
Compare
graciecooper
reviewed
Apr 6, 2026
graciecooper
reviewed
Apr 6, 2026
… + fix immedate tickle + remove hardcoded values
f1618bc to
50d9b27
Compare
cfc6237 to
b62a511
Compare
vvoicehovics
commented
Apr 7, 2026
|
|
||
|
|
||
| @UiThread | ||
| BaseMessageView(@NonNull Activity currentActivity, boolean manageStatusBarColor) { |
Contributor
Author
There was a problem hiding this comment.
- views set status bar color to black to prevent random color bar from activity show on top of styled in-app (black kind of fits all if i recall rationale). So, color is set, then unset when view closed.
- Now as we have overlay + in-app potentially showing simultaneously, their sets-unsets can leave it in incorrect state (e.g. 2nd unset changes it to the 1st set)
- dialog also does
Theme_Translucent_NoTitleBar_Fullscreen, which in theory should prevent any bar showing at all. This is what i observe in test app, this is what AIs conclude, though this is too specific for them not to get creative. - i cant categorically confirm setting color is not needed on any devices, the repository which had original rationale doesnt exist anymore.
so, the outcome here is to let in-app do what it was doing and the new channel doesnt touch status color until we have issues. I think this is better vs creating complex implementations for phantom problems we maybe had years ago
@graciecooper or you have idea why it's needed? there is related PR from @k-antipochkin here #63
Contributor
There was a problem hiding this comment.
Ya, I’m happy to leave it as-is for now rather than pre-emptively solving a problem that might not actually be a problem
graciecooper
reviewed
Apr 9, 2026
| @@ -1,5 +1,9 @@ | |||
| # Changelog | |||
|
|
|||
| ## 7.13.0 | |||
Contributor
There was a problem hiding this comment.
sorry i've stolen your version number with a new bugfix ! 😎
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
https://mobius.visualstudio.com/Backstage/_workitems/edit/277632
New Overlay Messaging channel with following API
XRecorder_20260401_03.mp4
Can coexist with in-app
Breaking Changes
Release Checklist
Prepare:
Bump versions in:
Integration tests
T&T Only
Mobile Only
Deferred Deep Links
Combined
Release Procedure
devtomaster