🌱 scripts: skip cert-manager install if already present on cluster#2650
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the install script to avoid reinstalling cert-manager when it’s already present on the cluster (Fixes #1501).
Changes:
- Adds a pre-check for cert-manager presence before applying the upstream cert-manager manifest.
- Logs when cert-manager installation is skipped.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Also check cert-manager deployments, not just CRD Fixes operator-framework#1501 Signed-off-by: Todd Short <tshort@redhat.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2650 +/- ##
==========================================
+ Coverage 68.90% 68.92% +0.01%
==========================================
Files 141 141
Lines 10005 10005
==========================================
+ Hits 6894 6896 +2
+ Misses 2595 2594 -1
+ Partials 516 515 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
adding the approval since Rashmi has lgtm'ed and it looks good /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva, rashmigottipati The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 1bf20d8
into
operator-framework:main
Fixes #1501
Description
Reviewer Checklist