Fix pin-bundle-images list element seperator on ERROR

[amartyasinha]

When a bundle lookup failed, the error token was getting concatenated to the previous bundle reference, which made CI logs misleading during debugging. For example, a nova bundle failure appeared as if neutron failed because "ERROR" was appended to the neutron bundle ref.

Misleading CI log blaming neutron:

+ skopeo copy docker://quay.io/openstack-k8s-operators/neutron-operator-bundle:26247a82c50be671c34c3646900aeefd795e2748ERROR: dir:tmp/bindata/tmp
FATA[0000] Invalid source name docker://quay.io/openstack-k8s-operators/neutron-operator-bundle:26247a82c50be671c34c3646900aeefd795e2748ERROR:: invalid reference format
+ RC=1
+ '[' 1 -eq 0 -o 5 -ge 5 ']'
+ exit 1
make: *** [Makefile:174: bindata] Error 1

Actual failure on nova, but not getting caught in CI due to missing ,:

./hack/pin-bundle-images.sh
,quay.io/openstack-k8s-operators/barbican-operator-bundle:4ba81106621be23697cbf660e73222bf727cbf86,quay.io/openstack-k8s-operators/cinder-operator-bundle:7d895a78aba4c0dc473ad70f5cda3ddb23ce2328,quay.io/openstack-k8s-operators/designate-operator-bundle:a4d9e9923a7c2e4d7df37d0c93e447d3cf8b3c50,quay.io/openstack-k8s-operators/glance-operator-bundle:5d3b9a38d41fc907da8294224cf73addc56325f3,quay.io/openstack-k8s-operators/heat-operator-bundle:bc6ef34fe170e7e48b40cdafb9fdbb93e594c198,quay.io/openstack-k8s-operators/horizon-operator-bundle:e2ac360661926baa6f4a7057a93db1d23c53bce5,quay.io/openstack-k8s-operators/infra-operator-bundle:5476763a36b6baebc82b0fe38e966e15a7881270,quay.io/openstack-k8s-operators/ironic-operator-bundle:b8fc3a4b05217d5b450a69e6f2064e1e471f3f3c,quay.io/openstack-k8s-operators/keystone-operator-bundle:c146da0da0d63e73760b568f63e125dac80ccfcc,quay.io/openstack-k8s-operators/manila-operator-bundle:523bbc8113634169b0dbe573511c8e49b993cead,quay.io/openstack-k8s-operators/mariadb-operator-bundle:564a51226a2a01ce3b5501d2b8a8fba133a02787,quay.io/openstack-k8s-operators/neutron-operator-bundle:26247a82c50be671c34c3646900aeefd795e2748ERROR: Failed to find bundle image SHA for:
  MOD_PATH: github.com/auniyal61/nova-operator/api
  BASE: nova
  REF: b54a701efcaf
  REPO_URL: quay.io/auniyal61
  REPO_CURL_URL: https://quay.io/api/v1/repository/auniyal61
  Bundle: quay.io/auniyal61/nova-operator-bundle:b54a701efcaf
,EMPTY_SHA:b54a701efcaf:https://quay.io/api/v1/repository/auniyal61

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amartyasinha
Once this PR has been reviewed and has the lgtm label, please assign stuggi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

OpenStackControlPlane CRD Size Report

Metric	Value
CRD JSON size	322464 bytes (315KB)
Base branch size	322464 bytes
Change	+0.00%
Status	yellow — growing

Threshold reference

Color	Range	Meaning
🟢 green	< 300KB	Comfortable
🟡 yellow	300–400KB	Growing
🟠 orange	400–750KB	Concerning
🔴 red	> 750KB	Approaching 1.5MB etcd limit (cut in half to allow space for update)

[amartyasinha]

Now failing with correct error msg, no longer blaming other bundle:

2026-04-24 10:02:14.607369 \| controller \|     - ++ hack/pin-bundle-images.sh
--
2026-04-24 10:02:14.607375 \| controller \|     - ''
2026-04-24 10:02:14.607382 \| controller \|     - 'ERROR: Failed to find bundle image SHA for:'
2026-04-24 10:02:14.607388 \| controller \|     - '  MOD_PATH: github.com/auniyal61/nova-operator/api'
2026-04-24 10:02:14.607394 \| controller \|     - '  BASE: nova'
2026-04-24 10:02:14.607404 \| controller \|     - '  REF: b54a701efcaf'
2026-04-24 10:02:14.607538 \| controller \|     - '  REPO_URL: 38.102.83.222:5001/openstack-k8s-operators'
2026-04-24 10:02:14.607548 \| controller \|     - '  REPO_CURL_URL: http://38.102.83.222:5001/v2/openstack-k8s-operators'
2026-04-24 10:02:14.607554 \| controller \|     - '  Bundle: 38.102.83.222:5001/openstack-k8s-operators/nova-operator-bundle:b54a701efcaf'
2026-04-24 10:02:14.607560 \| controller \|     - EMPTY_SHA:nova:b54a701efcaf:http://38.102.83.222:5001/v2/openstack-k8s-operators
2026-04-24 10:02:14.607567 \| controller \|     - + BUNDLES=,quay.io/openstack-k8s-operators/barbican-operator-bundle:4ba81106621be23697cbf660e73222bf727cbf86,quay.io/openstack-k8s-operators/cinder-operator-bundle:7d895a78aba4c0dc473ad70f5cda3ddb23ce2328,quay.io/openstack-k8s-operators/designate-operator-bundle:a4d9e9923a7c2e4d7df37d0c93e447d3cf8b3c50,quay.io/openstack-k8s-operators/glance-operator-bundle:5d3b9a38d41fc907da8294224cf73addc56325f3,quay.io/openstack-k8s-operators/heat-operator-bundle:bc6ef34fe170e7e48b40cdafb9fdbb93e594c198,quay.io/openstack-k8s-operators/horizon-operator-bundle:e2ac360661926baa6f4a7057a93db1d23c53bce5,quay.io/openstack-k8s-operators/infra-operator-bundle:5476763a36b6baebc82b0fe38e966e15a7881270,quay.io/openstack-k8s-operators/ironic-operator-bundle:b8fc3a4b05217d5b450a69e6f2064e1e471f3f3c,quay.io/openstack-k8s-operators/keystone-operator-bundle:c146da0da0d63e73760b568f63e125dac80ccfcc,quay.io/openstack-k8s-operators/manila-operator-bundle:523bbc8113634169b0dbe573511c8e49b993cead,quay.io/openstack-k8s-operators/mariadb-operator-bundle:564a51226a2a01ce3b5501d2b8a8fba133a02787,quay.io/openstack-k8s-operators/neutron-operator-bundle:26247a82c50be671c34c3646900aeefd795e2748
2026-04-24 10:02:14.607583 \| controller \|     - + exit 1
2026-04-24 10:02:14.607590 \| controller \|     - 'make: *** [Makefile:174: bindata] Error 1'

Ref: https://softwarefactory-project.io/zuul/t/rdoproject.org/build/af1a8c050e774ad4bb685290e84ec070/log/job-output.txt#2518-2528