CNTRLPLANE-2796: promote the event-ttl feature#2722
CNTRLPLANE-2796: promote the event-ttl feature#2722tjungblu wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@tjungblu: This pull request references CNTRLPLANE-2796 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @tjungblu! Some important instructions when contributing to openshift/api: |
📝 WalkthroughWalkthroughThe changes reorder and expand the features.md table, inserting a contiguous block of new rows and moving EventTTL. features/features.go updates multiple feature-gate enablement entries to include Default and OKD contexts in addition to existing TechPreview/DevPreview settings. Four FeatureGate manifest files (Hypershift and SelfManagedHA, Default and OKD) move EventTTL from the disabled to the enabled list. Several CRD manifest files defining the KubeAPIServer custom resource (multiple profile variants) are deleted, and one CRD file has a metadata annotation removed. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@tjungblu: This pull request references CNTRLPLANE-2796 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This adds the event-ttl feature to the default feature set. Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
ebfc3fe to
73f6501
Compare
|
@tjungblu: This pull request references CNTRLPLANE-2796 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tjungblu: This pull request references CNTRLPLANE-2796 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
What about the OTA migration prevents these tests from being implemented?
If we can't reasonably get to five tests (i.e it doesn't make sense to have five tests) we can override that requirement, but that is generally few and far between. If you are confident that less than five tests is comprehensive enough coverage for this feature, an override seems fine on that requirement. If existing suites and/or jobs are not suitable for running these tests, it should be possible to create a new suite/job that is run to execute your tests in a more appropriate environment.
QE-side coverage is no longer sufficient for feature promotion. If you strongly believe your feature is an exception, you'll need to file an SBAR for the feature promotion and include a plan for how you are going to catch regressions to the feature until automated regression tests that report into component readiness are added. |
|
@tjungblu: This pull request references CNTRLPLANE-2796 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
@tjungblu: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This adds the event-ttl feature to the default feature set.
Introduction PR in #2520
Corresponding enhancement in
openshift/enhancements#1857
We’re seeking an exception for the automated FeatureGate verification on this promotion. While a functional e2e test has now merged and is reporting into the component readiness dashboard, we are only contributing this single test case to protect CI stability.
Changing the event-ttl causes unavoidable data loss for a period of time, which would negatively impact monitortests and other invariant testing that requires a full event history. To avoid compromising these other CI signals, we have focused on a 5-minute soak as our primary validator rather than expanding to the five-test requirement.
Furthermore, API boundaries are covered by unit tests in this repository. This is a mature upstream setting already running on large-scale clusters via support exceptions. Given this production track record, the merged CI coverage, and the risks additional tests pose to the broader suite, we believe this is ready for Default.