SPLAT-2637: Promoting gate AWSServiceLBNetworkSecurityGroup to GA

[mtulio]

PR blocked by:

• tests SPLAT-2220: tests/ote: introduce openshift-only e2e to validate feature by feature gate cloud-provider-aws#126
• EP SPLAT-2137: Support Security Group on NLB for Default router on AWS enhancements#1802

Is blocking GA on Hypershift: TPNU ref openshift/hypershift#7460

Feature OCPSTRAT-1553 / SPLAT-2553

Tests cloud-provider-aws-e2e-openshift have been added to this feature, as long with the cloud-provider-aws-e2e exercising CCM though OTE.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@mtulio: This pull request references SPLAT-2637 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

PR blocked by:

• tests SPLAT-2220: tests/ote: introduce openshift-only e2e to validate feature by feature gate cloud-provider-aws#126
• EP SPLAT-2137: Support Security Group on NLB for Default router on AWS enhancements#1802

Is blocking GA on Hypershift: TPNU ref openshift/hypershift#7460

Feature OCPSTRAT-1553 / SPLAT-2553

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 0dc5047f-aadc-4d37-be11-69b04fbcda95

📥 Commits

Reviewing files that changed from the base of the PR and between e188bac and 98fa4f3.

📒 Files selected for processing (4)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• features.md

---

📝 Walkthrough

Walkthrough

The AWSServiceLBNetworkSecurityGroup feature gate was refactored to support cluster-profile-aware configuration. The feature gate declaration was updated to include two separate enable branches: one targeting SelfManaged profiles and another targeting Hypershift profiles. Correspondingly, AWSServiceLBNetworkSecurityGroup was transitioned from disabled to enabled status in multiple feature gate manifests, including the Default and OKD configurations. Documentation in features.md was updated to reflect these configuration changes.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: promoting the AWSServiceLBNetworkSecurityGroup feature gate to GA, which aligns with all file modifications.
Description check	✅ Passed	The description is related to the changeset, providing context about the feature promotion, blocked dependencies, test coverage, and verification status.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	PR does not modify any Ginkgo test files; changes are limited to feature gate configuration, documentation, and YAML manifests.
Test Structure And Quality	✅ Passed	This PR does not introduce or modify any Ginkgo test code. The only test file uses the standard Go testing framework, not Ginkgo patterns.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[mtulio]

/test ?

[qodo-code-review]

PR-Agent: could not fine a component named ? in a supported language in this PR.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

Hello @mtulio! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[mtulio]

/test all

[qodo-code-review]

ⓘ Your monthly quota for Qodo has expired. Upgrade your plan

ⓘ Paying users. Check that your Qodo account is linked with this Git user account

[mtulio]

/test verify-feature-promotion
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview

[qodo-code-review]

ⓘ Your monthly quota for Qodo has expired. Upgrade your plan

ⓘ Paying users. Check that your Qodo account is linked with this Git user account

[openshift-ci-robot]

@mtulio: This pull request references SPLAT-2637 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

PR blocked by:

• tests SPLAT-2220: tests/ote: introduce openshift-only e2e to validate feature by feature gate cloud-provider-aws#126
• EP SPLAT-2137: Support Security Group on NLB for Default router on AWS enhancements#1802

Is blocking GA on Hypershift: TPNU ref openshift/hypershift#7460

Feature OCPSTRAT-1553 / SPLAT-2553

Tests cloud-provider-aws-e2e-openshift have been added to this feature, as long with the cloud-provider-aws-e2e exercising CCM though OTE.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mtulio]

e2e-aws-ovn-hypershift-conformance is legitm, I just created the skip openshift/release#75211 while we are waiting for the feature PR in hypershift openshift/hypershift#7460

[mtulio]

verify-feature-promotion is also failing locally.

$ make verify-feature-promotion 
hack/verify-promoted-features-pass-tests.sh
comparing against master
...
Query sippy for all test run results for pattern "FeatureGate:AWSServiceLBNetworkSecurityGroup]" on variant main.JobVariant{Cloud:"aws", Architecture:"amd64", Topology:"single", NetworkStack:""}
Querying sippy release 4.22 for test run results
F0224 11:24:48.988679 2287144 root.go:64] Error running codegen: Get "https://sippy.dptools.openshift.org/api/tests?filter=%7....erator%22%3A%22and%22%7D&period=default&release=4.22":
 context deadline exceeded (Client.Timeout exceeded while awaiting headers)
make: *** [Makefile:95: verify-feature-promotion] Error 255

[mtulio]

/test e2e-aws-ovn-techpreview

[qodo-code-review]

PR-Agent: could not fine a component named e2e-aws-ovn-techpreview in a supported language in this PR.

[mtulio]

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ccm-techpreview

[openshift-ci]

@mtulio: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ccm-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f8192380-1722-11f1-9762-ff925bc266de-0

[mtulio]

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ccm-techpreview

[openshift-ci]

@mtulio: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ccm-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/beb86480-18a2-11f1-8079-b2880f72d5dc-0

[mtulio]

/test all

[mtulio]

/pipeline required

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[mtulio]

/test verify

[qodo-code-review]

PR-Agent: could not fine a component named verify in a supported language in this PR.

[jcpowermac]

/lgtm

[qodo-code-review]

Review Summary by Qodo

Promote AWSServiceLBNetworkSecurityGroup feature gate to GA

✨ Enhancement

Walkthroughs

Description

• Promote AWSServiceLBNetworkSecurityGroup feature gate to GA
• Enable feature in Default and OKD feature sets
• Update Go runtime image version to 1.25
• Reorganize feature gate documentation and manifests

Diagram

flowchart LR
  A["AWSServiceLBNetworkSecurityGroup<br/>TechPreviewNoUpgrade"] -->|"Promote to GA"| B["Enabled in Default<br/>and OKD"]
  C["Go 1.24"] -->|"Update runtime"| D["Go 1.25"]
  B --> E["Update feature gate<br/>manifests"]
  E --> F["Reorganize documentation"]

Loading

File Changes

1. features/features.go ✨ Enhancement +6/-6

Promote AWSServiceLBNetworkSecurityGroup to GA

• Promote AWSServiceLBNetworkSecurityGroup from TechPreviewNoUpgrade to Default feature set
• Add inDefault() and inOKD() to enable() call alongside existing preview flags
• Fix indentation alignment for consistency

features/features.go

---

2. Makefile Dependencies +1/-1

Update Go runtime image to 1.25

• Update RUNTIME_IMAGE_NAME Go version from 1.24 to 1.25
• Update OpenShift release version from 4.20 to 4.22

Makefile

---

3. features.md 📝 Documentation +1/-1

Update feature gate documentation table

• Move AWSServiceLBNetworkSecurityGroup from TechPreviewNoUpgrade section to GA section
• Update feature gate status to show enabled across all feature sets

features.md

---

View more (4)

4. payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml ⚙️ Configuration changes +3/-3

Enable AWSServiceLBNetworkSecurityGroup in Default

• Remove AWSServiceLBNetworkSecurityGroup from disabled features list
• Add AWSServiceLBNetworkSecurityGroup to enabled features list

payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

---

5. payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml ⚙️ Configuration changes +3/-3

Enable AWSServiceLBNetworkSecurityGroup in OKD

• Remove AWSServiceLBNetworkSecurityGroup from disabled features list
• Add AWSServiceLBNetworkSecurityGroup to enabled features list

payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml

---

6. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml ⚙️ Configuration changes +3/-3

Enable AWSServiceLBNetworkSecurityGroup in Default

• Remove AWSServiceLBNetworkSecurityGroup from disabled features list
• Add AWSServiceLBNetworkSecurityGroup to enabled features list

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml

---

7. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml ⚙️ Configuration changes +3/-3

Enable AWSServiceLBNetworkSecurityGroup in OKD

• Remove AWSServiceLBNetworkSecurityGroup from disabled features list
• Add AWSServiceLBNetworkSecurityGroup to enabled features list

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

ⓘ The new review experience is currently in Beta. Learn more

[openshift-ci-robot]

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcpowermac
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[mtulio]

Based in verify-feature-promotion, I've updated this PR to focus on HA profile as that's the target for GA.

[mtulio]

Hey @JoelSpeed , would you mind reviewing this PR? I am awaiting for tests to populate Sippy, meanwhile looking for feedback to have time to fix anything that might not be ready (except those tests). Thanks in advance.

Holding this PR until get tests populated for verify-feature-promotion:

/hold

[mtulio]

Just ran the make verify-feature-promotion and got:

Query sippy for all test run results for feature gate "AWSServiceLBNetworkSecurityGroup" on clusterProfile ["SelfManagedHA"]
Query sippy for all test run results for pattern "FeatureGate:AWSServiceLBNetworkSecurityGroup]" on variant main.JobVariant{Cloud:"aws", Architecture:"amd64", Topology:"ha", NetworkStack:""}
Querying sippy release 4.22 for test run results
Query sippy for all test run results for pattern "FeatureGate:AWSServiceLBNetworkSecurityGroup]" on variant main.JobVariant{Cloud:"aws", Architecture:"amd64", Topology:"single", NetworkStack:""}
Querying sippy release 4.22 for test run results
Sufficient CI testing for "AWSServiceLBNetworkSecurityGroup".

I am addressing the Joel's feedback of HCP TP strategy in parallel of self-managed.

[openshift-ci]

@mtulio: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mtulio]

/pipeline required

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor