feat: new editor design by rpenido · Pull Request #642 · openedx/xblock-lti-consumer

rpenido · 2026-04-09T03:17:50Z

This PR implements a new Edit dialog for the LTI Consumer block

Testing instructions

Private ref: FAL-4322

openedx-webhooks · 2026-04-09T03:17:56Z

Thanks for the pull request, @rpenido!

This repository is currently maintained by @Faraz32123.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

navinkarkera

@rpenido The editing experience is much better now!

Left some comments about minor typos and small bugs caught by AI.

I noticed that on clicking fullscreen button the modal goes to left side as seen in the screenshot and the Previous button gets misaligned. Is this expected?

navinkarkera · 2026-04-13T09:59:13Z

+      // Transform the custom_parameters field into a list
+      if ("custom_parameters" in submitData.values) {
+        const customParameters = submitData.values.custom_parameters;
+        submitData.values.custom_parameters = JSON.parse(customParameters);


We should probably use try-catch block for JSON.parse of user input.

navinkarkera · 2026-04-13T09:59:17Z

+      // Transform the lti_1p3_redirect_uris field into a list
+      if ("lti_1p3_redirect_uris" in submitData.values) {
+        const redirectUris = submitData.values.lti_1p3_redirect_uris;
+        submitData.values.lti_1p3_redirect_uris = JSON.parse(redirectUris);


navinkarkera · 2026-04-13T10:01:24Z

+
+      runtime.notify("save", { state: "start" });
+
+      $.ajax({


Missing contentType: 'application/json'.

navinkarkera · 2026-04-13T10:09:25Z

    Arguments:
        course_key (opaque_keys.edx.locator.CourseLocator): Course Key
    """
+    return True


Ops! Thanks!

- Introduce Lti1p3Passport model to centralize LTI 1.3 keys and credentials - Move lti_1p3_internal_private_key, lti_1p3_internal_private_key_id, lti_1p3_internal_public_jwk, lti_1p3_client_id, lti_1p3_tool_public_key, and lti_1p3_tool_keyset_url fields from LtiConfiguration to Lti1p3Passport - Add ForeignKey relationship from LtiConfiguration to Lti1p3Passport - Implement passport-based key generation and retrieval - Add clean() validation to Lti1p3Passport to ensure at least one of lti_1p3_tool_public_key or lti_1p3_tool_keyset_url is set - Update validation in LtiConfiguration.clean() to check for passport presence instead of tool key fields - Refactor get_or_create_local_lti_config() to handle passport creation and sync block/passport key configurations - Update API endpoints to work with passport ID instead of configuration ID - Add admin interface for Lti1p3Passport model - Refactor access_token_endpoint and public_keyset_endpoint to use passport ID - Update API and views to work with the new passport model - Generate migration to remove fields from LtiConfiguration table - Update data migration to copy existing configurations to the new Passport model - Update XBlock to store passport ID instead of config ID - Fix copy-paste issue in resource_link_id generation

* Add signal handlers to delete LTI configurations when xblocks or library blocks are deleted * Ensure LTI configurations are properly cleaned up when associated blocks are removed from the system * Update documentation for LTI 1.3 configuration changes to inform users about potential regeneration of client IDs and URLs when public keys are changed

• Fixed spelling errors (configurtion → configuration, url → URL) • Improved log messages to be more informative • Used more descriptive variable names (id_list → block_locations) • Maintained consistent code style and import organization

…_1p3_passport

- Added 'name' and 'context_key' fields to Lti1p3Passport model - Modified LtiConfiguration to populate these fields when creating passports - Updated admin interface to display new fields - Added migration to populate existing passports with name and context_key - Updated string representation of passport to include name - Made 'location' field in LtiConfiguration unique to prevent race conditions This fixes a race condition that occurred when get_or_create was called with the same location multiple times, which resulted in duplicate rows with identical locations being created simultaneously.

Adds tests covering possible cases

Fixes: openedx#628

Fixes: openedx#637

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 9, 2026

openedx-webhooks added this to Contributions Apr 9, 2026

github-project-automation bot moved this to Needs Triage in Contributions Apr 9, 2026

rpenido force-pushed the rpenido/FAL-4322/new-editor-design branch from 782ff8f to 36ce6a2 Compare April 9, 2026 03:20

mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 9, 2026

navinkarkera reviewed Apr 13, 2026

View reviewed changes

navinkarkera added 23 commits April 13, 2026 16:50

fix: lint issues

3979b16

feat: install openedx-events

8a268b3

fix: model label

2e6ce8b

fix: handle no location

999156d

test: fix tests

de50bae

fix: lint issues

a5ce602

fixup! fix: lint issues

64d7aae

test: add signal tests

f31fa61

fix: coverage

b34d803

refactor(models): rename create_lti_1p3_passport to get_or_create_lti…

3ac8dd3

…_1p3_passport

fix: copy-paste bug when both public key and keyset url is specified

fb89f25

fix: lint issues

ce8ab7c

test: improve coverage

84c2e78

refactor(views): remove unnecessary db call

1057e62

fix: create name only if block is available

d96b929

fix: test

8c8df22

refactor: migration

a6f3807

chore: upgrade

17938cc

refactor: avoid duplicate signal triggers

8096344

rpenido force-pushed the rpenido/FAL-4322/new-editor-design branch 3 times, most recently from df351e8 to 33750d0 Compare April 13, 2026 21:16

navinkarkera added 6 commits April 14, 2026 15:50

fix: migration for missing location field in configurations

3a41150

Adds tests covering possible cases

fix: lint issues

4831f17

fix: ags result endpoint to work with or without ending slash

2ff2be0

Fixes: openedx#628

fix: allow blank comment in scores api endpoint

efc8a47

Fixes: openedx#637

fix: use correct deep linking launch uri as target_link_uri

570b9fb

fix: lint issues

64d301b

rpenido force-pushed the rpenido/FAL-4322/new-editor-design branch 19 times, most recently from 7d8ddc8 to 4039060 Compare April 17, 2026 22:53

feat: new editor design

aade929

rpenido force-pushed the rpenido/FAL-4322/new-editor-design branch from 4039060 to aade929 Compare April 17, 2026 23:13

Conversation

rpenido commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing instructions

Uh oh!

openedx-webhooks commented Apr 9, 2026

Uh oh!

navinkarkera left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rpenido commented Apr 9, 2026 •

edited

Loading