Conversation
|
Thanks for the pull request, @navinkarkera! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
e767912 to
8fa49be
Compare
8fa49be to
97cc25e
Compare
|
@navinkarkera can you rebase this and get the tests to green so we can get this reviewed. |
97cc25e to
d59b905
Compare
|
@feanil Done. Once the LTI xblock PR is merged, I can remove the temporary link to github branch and update this PR. |
| importlib_metadata # Used to access entry_points in i18n_api plugin | ||
| lxml[html_clean] # XML parser | ||
| lti-consumer-xblock>=9.14.2 | ||
| lti-consumer-xblock @ git+https://github.com/open-craft/xblock-lti-consumer@navin/fal-4318/split-config |
There was a problem hiding this comment.
TODO: Remove this before merging
ormsbee
left a comment
There was a problem hiding this comment.
I think this approach is fine. The only reason I'm not giving it an approval is because of the temporary requirements change pointing to a branch of the lti-consumer-block.
0d27e2d to
f3acdc9
Compare
This is required in cases where we want to be able to delete or update database rows related to children blocks on the deleted block. Fetching children after deletion is not possible, which is why this signal is useful
f3acdc9 to
ac57b20
Compare
|
@feanil This is ready to be merged. |
f3acdc9 to
ac57b20
Compare
Description
This is required in cases where we want to be able to delete or update database rows related to children blocks on the deleted block. Fetching children after deletion is not possible, which is why this signal is useful
Useful information to include:
Supporting information
Testing instructions
See PR: openedx/xblock-lti-consumer#627
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.