Skip to content

feat: add pre-delete signal#38289

Merged
feanil merged 5 commits intoopenedx:masterfrom
open-craft:navin/fal-4318/pre-delete-signal-for-lti
Apr 21, 2026
Merged

feat: add pre-delete signal#38289
feanil merged 5 commits intoopenedx:masterfrom
open-craft:navin/fal-4318/pre-delete-signal-for-lti

Conversation

@navinkarkera
Copy link
Copy Markdown
Contributor

Description

This is required in cases where we want to be able to delete or update database rows related to children blocks on the deleted block. Fetching children after deletion is not possible, which is why this signal is useful

Useful information to include:

  • Which edX user roles will this change impact? "Developer"

Supporting information

Testing instructions

See PR: openedx/xblock-lti-consumer#627

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Apr 6, 2026
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Apr 6, 2026

Thanks for the pull request, @navinkarkera!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Apr 6, 2026
@navinkarkera navinkarkera added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Apr 6, 2026
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Apr 6, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 6, 2026
@navinkarkera navinkarkera force-pushed the navin/fal-4318/pre-delete-signal-for-lti branch from e767912 to 8fa49be Compare April 7, 2026 14:26
@navinkarkera navinkarkera marked this pull request as ready for review April 13, 2026 14:52
@navinkarkera navinkarkera force-pushed the navin/fal-4318/pre-delete-signal-for-lti branch from 8fa49be to 97cc25e Compare April 13, 2026 14:52
@feanil
Copy link
Copy Markdown
Contributor

feanil commented Apr 13, 2026

@navinkarkera can you rebase this and get the tests to green so we can get this reviewed.

@navinkarkera navinkarkera force-pushed the navin/fal-4318/pre-delete-signal-for-lti branch from 97cc25e to d59b905 Compare April 14, 2026 09:52
@navinkarkera
Copy link
Copy Markdown
Contributor Author

@feanil Done. Once the LTI xblock PR is merged, I can remove the temporary link to github branch and update this PR.

Comment thread requirements/edx/kernel.in Outdated
importlib_metadata # Used to access entry_points in i18n_api plugin
lxml[html_clean] # XML parser
lti-consumer-xblock>=9.14.2
lti-consumer-xblock @ git+https://github.com/open-craft/xblock-lti-consumer@navin/fal-4318/split-config
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Remove this before merging

@navinkarkera navinkarkera marked this pull request as draft April 14, 2026 11:05
@feanil feanil requested a review from ormsbee April 14, 2026 18:24
Copy link
Copy Markdown
Contributor

@ormsbee ormsbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this approach is fine. The only reason I'm not giving it an approval is because of the temporary requirements change pointing to a branch of the lti-consumer-block.

@navinkarkera navinkarkera force-pushed the navin/fal-4318/pre-delete-signal-for-lti branch 3 times, most recently from 0d27e2d to f3acdc9 Compare April 21, 2026 07:32
@navinkarkera navinkarkera marked this pull request as ready for review April 21, 2026 16:21
This is required in cases where we want to be able to delete or update
database rows related to children blocks on the deleted block. Fetching
children after deletion is not possible, which is why this signal is
useful
@navinkarkera navinkarkera force-pushed the navin/fal-4318/pre-delete-signal-for-lti branch from f3acdc9 to ac57b20 Compare April 21, 2026 16:22
@navinkarkera navinkarkera removed the create-sandbox open-craft-grove should create a sandbox environment from this PR label Apr 21, 2026
@navinkarkera
Copy link
Copy Markdown
Contributor Author

@feanil This is ready to be merged.

@navinkarkera navinkarkera force-pushed the navin/fal-4318/pre-delete-signal-for-lti branch from f3acdc9 to ac57b20 Compare April 21, 2026 16:22
@feanil feanil merged commit f174486 into openedx:master Apr 21, 2026
54 of 58 checks passed
@github-project-automation github-project-automation Bot moved this from Waiting on Author to Done in Contributions Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants