fix(client): treat empty OPENAI_BASE_URL as unset and fall back to default#2980
Open
NIK-TIGER-BILL wants to merge 1 commit intoopenai:mainfrom
Open
fix(client): treat empty OPENAI_BASE_URL as unset and fall back to default#2980NIK-TIGER-BILL wants to merge 1 commit intoopenai:mainfrom
NIK-TIGER-BILL wants to merge 1 commit intoopenai:mainfrom
Conversation
…fault When OPENAI_BASE_URL is set to an empty string, os.environ.get() returns "" which is falsy but not None, so the second `if base_url is None` check never fires and the default API URL is never used. Using `or None` converts empty strings to None, allowing the fallback to proceed correctly. Fixes openai#2927
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
OPENAI_BASE_URLis set to an empty string (e.g.,export OPENAI_BASE_URL=""),os.environ.get("OPENAI_BASE_URL")returns""— which is notNone. As a result, the secondif base_url is Nonecheck never fires, the defaulthttps://api.openai.com/v1fallback is skipped, and the client tries to connect to an empty URL, producing a confusingAPIConnectionError.Solution
Convert the empty string to
Noneusingor None, so the fallback fires correctly:Applied to both the sync
OpenAIclient and the asyncAsyncOpenAIclient.Testing
export OPENAI_BASE_URL="" && python -c "from openai import OpenAI; OpenAI().models.list()"— previously raisedAPIConnectionError, now falls back to default endpointFixes #2927