Skip to content

Surface error on WS close, only retry retryable errors#13104

Open
rasmusrygaard wants to merge 1 commit intomainfrom
dev/rasmus/surface_error_ws_close
Open

Surface error on WS close, only retry retryable errors#13104
rasmusrygaard wants to merge 1 commit intomainfrom
dev/rasmus/surface_error_ws_close

Conversation

@rasmusrygaard
Copy link
Contributor

@rasmusrygaard rasmusrygaard commented Feb 28, 2026

Two fixes for websocket error conditions:

  1. When we close the websocket on the server, we sometimes provide additional context in the close message. We should surface this to the client so they can act on it. Typically this would be validation failures that the client needs to act on.
  2. When we hit one of those conditions, the websocket client will retry 5 times by default. This is not useful if we get a non-retryable error back.

This PR encodes a list of retryable websocket codes. All other codes will break from the retry loop and surface the client-provided error.
Screenshot 2026-02-27 at 20 02 28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant