chore: remove SkillMetadata.permissions and derive skill sandboxing from permission_profile#13061
Open
chore: remove SkillMetadata.permissions and derive skill sandboxing from permission_profile#13061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change removes the compiled permissions field from skill metadata and keeps permission_profile as the single source of truth.
Skill loading no longer compiles skill permissions eagerly. Instead, the zsh-fork skill escalation path compiles
skill.permission_profilewhen it needs to determine the sandbox to apply for a skill script.Behavior change
For skills that declare:
we now treat that the same as having no skill permissions override, instead of creating and using a default readonly sandbox. This change makes the behavior more intuitive:
Overall, this makes skill sandbox behavior easier to understand and more predictable.