Conversation
b26c6ce to
615da1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Skill script approvals currently replace the active sandbox with only the permissions declared in the skill's
openai.yaml. That means attaching a script to a skill can make it less capable than the same script would be without the skill, which is the opposite of what additive skill permissions are supposed to do.This change makes skill permissions additive by default so a skill can request extra access without discarding the current turn sandbox. For cases where a skill author really does want a fully specified sandbox, it also adds an explicit opt-in for exact replacement semantics.
What changed
permissions.mode, withmergeas the default andexactas an opt-in overridePermissionProfile, while exact-mode skills compile a standalonePermissionsobjectzsh-forkskill escalation to merge the skill's declared permission profile into the current turn sandbox by defaultpermissions.mode: exact, including explicit approval copy that calls out the exact-sandbox behaviorpermissionsshape in the sampleopenai.yamlreferenceTesting
permissions.mode: exactskill_approvalcoverage for merged session approvals and exact-mode replacementcargo test -p codex-core