Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0fa571cbe3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| }; | ||
| let mut metadata = outcome.metadata; | ||
| let memory_mode = outcome.memory_mode.unwrap_or_else(|| "enabled".to_string()); |
There was a problem hiding this comment.
Do not default to "enabled" here. For rollouts without session_meta.memory_mode (legacy files, or threads later marked polluted only in DB), this path overwrites the current DB value and re-enables memory generation. A read-repair/reconcile can therefore silently undo disabled/polluted state.
Useful? React with 👍 / 👎.
| ); | ||
| } | ||
| let mut metadata = outcome.metadata; | ||
| let memory_mode = outcome.memory_mode.unwrap_or_else(|| "enabled".to_string()); |
There was a problem hiding this comment.
Backfill now defaults missing rollout memory_mode to "enabled" and writes it back unconditionally. On any backfill pass over legacy rollouts, existing threads.memory_mode values can be clobbered, causing polluted/disabled threads to become eligible for stage1/phase2 processing again.
Useful? React with 👍 / 👎.
1 participant
Add a feature flag to disable memory creation for "polluted"