Conversation
ofaurax
left a comment
ofaurax
left a comment
There was a problem hiding this comment.
Can we use icons from a coherent iconset, so that they have the same look'n'feel?
| vertical-align: middle; | ||
| float: none; | ||
| } | ||
|
|
There was a problem hiding this comment.
This can be factorized. Also class names should be semantic: what is icon1? Which use?
| echo '<input type="hidden" name="token" value="'.$token.'" />'; | ||
| } | ||
| ?> | ||
| <img class="icon1" src="pictures/magnifying-glass-tilted-left-svgrepo-com.svg"> |
There was a problem hiding this comment.
please use "img" for images, as they are not "pictures" (like photos) but icons
| echo ' [<a href="http://www.youtube.com/results?search_query='.urlencode($c.', '.$l[$i+1].', '.$l[$i+2]).'">youtube</a>]'; | ||
| echo ' [<a href="http://musicainfo.net/quiksrch.php?vol='.urlencode($c).'">musicainfo</a>]'; | ||
| echo ' [<a href="http://www.youtube.com/results?search_query='.urlencode($c.', '.$l[$i+1].', '.$l[$i+2]).'"><img class="icon2" src="pictures/youtube-svgrepo-com.svg" alt="youtube-logo"> youtube</a>]'; | ||
| echo ' [<a href="http://musicainfo.net/quiksrch.php?vol='.urlencode($c).'"><img class="icon2" src="pictures/web-svgrepo-com.svg" alt="web-logo">musicainfo</a>]'; |
There was a problem hiding this comment.
alt attribute should be used to aid visual impaired people.
So you might add a real description, like "youtube logo" rather than an ID.
Can't we use musicainfo logo rather than a generic web one?
It should be checked, but if the image is only used for decoration, I think we can use an empty alt=""
|
Request an account to download icon, and need to give credits. To use these icons, a credit section or page must be added to arvin. Advantage of svgrepo.com is that we don't have to attribute them the origin of icon (see https://www.svgrepo.com/page/licensing/). |
|
OK, so perhaps we can go with icons from svgrepo, but using duotone that we can theme black/pink so that we get something coherent |
2 participants
Add icons to actions to improve ergonomy and global aspect.
Related to issue #3
NOT TESTED YET !