Conversation
Fil
approved these changes
Mar 11, 2026
Contributor
Fil
left a comment
Fil
left a comment
There was a problem hiding this comment.
I've added an offsets test that sets the offset to 0, then back to 0.5 and overlays the two images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having a
typeof it === "undefined"check, use the newsetOffsetso that we it’s more explicit what offset is used for testing. This should make it easier to adopt Vitest and/or change the offset used for testing in the future.This also fixes explicitly passes Plot’s offset to axis.offset where we use d3-axis. But this currently has no effect on tests since d3-axis defaults to an offset of 0.5 in a headless environment, which is the same offset we use for Plot tests, even though Plot now defaults to an offset of 0 in a headless environment.