fix: parse un-exploded query param to map#101
Merged
mromaszewicz merged 1 commit intooapi-codegen:mainfrom Mar 2, 2026
Merged
Conversation
This fixes an issue where query parameters
that are objects with additional properties
cannot be parsed into their values. For example,
a query parameter like `tags=foo,bar,bim,baz` should
end up becoming:
```go
map[string]string{
"foo": "bar",
"bim": "baz",
}
```
This adheres to the [spec](https://swagger.io/docs/specification/v3_0/serialization/#query-parameters)
for paramters of style=form and explode=false.
Fixes: oapi-codegen/oapi-codegen#698
Signed-off-by: Alex Dulin <alex@morningconsult.com>
Member
|
This change is ok, but it doesn't quite fix oapi-codegen/oapi-codegen#698, because in that case, you've got a struct with a map for additional properties, and a custom JSON unmarshaler which knows how to handle it. We'd need something along those lines for parameters as well. It will work in the case where you have an empty schema with only additional properties, since that's converted to a map. |
mromaszewicz
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where query parameters that are objects with additional properties cannot be parsed into their values. For example, a query parameter like
tags=foo,bar,bim,bazshould end up becoming:This adheres to the spec for paramters of style=form and explode=false.
Improves the problem described in oapi-codegen/oapi-codegen#698 for empty schemas with additional properties, but doesn't address the issue of a non-empty schema with additional properties.