Merged
Conversation
roman-khimov
requested review from
End-rey,
carpawell and
cthulhu-rider
as code owners
It'll be just `object search` using v2 API internally. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
drop-search-v1
branch
from
6ded3fe to
acb4be1
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3931 +/- ##
========================================
Coverage 26.82% 26.82%
========================================
Files 677 670 -7
Lines 44723 44294 -429
========================================
- Hits 11997 11883 -114
+ Misses 31613 31308 -305
+ Partials 1113 1103 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roman-khimov
commented
Apr 9, 2026
cthulhu-rider
approved these changes
Apr 10, 2026
SearchV2 was initially delivered in 0.45.0 on Feb 27 2025 which means it's more than a year in production and all known code has migrated to it. Old Search API is insecure, so we can't support it forever. Signed-off-by: Roman Khimov <roman@nspcc.ru>
They're still useful in tests for now, but they should never be used for any real user-facing actions. Signed-off-by: Roman Khimov <roman@nspcc.ru>
This code is internal and only used in tests, no need for additional logic. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
drop-search-v1
branch
from
acb4be1 to
851a43b
Compare
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.