test: wire up toml parser to toml_test_harness#152
test: wire up toml parser to toml_test_harness#152CosmicHorrorDev wants to merge 1 commit intonot-fl3:masterfrom
toml_test_harness#152Conversation
|
worth mentioning that this is just wiring up the decoding half. there's still encoding to do, but that can be a separate PR |
|
First of all, great work, thanks for PR!
We never intended to support full toml specification - it is a complicated format and for nanoserde the goal for toml was simple ini-like files. I would say - it is a great tool for development, but I would rather only commit the tests that were helpful during the development in a form of normal #[test]. |
that's totally fine! it might be worth adding a note on the README and/or docs.rs page saying that the toml parser (and potentially the others) aren't intended to be spec-compliant Re: yeahhhh, that is quite a few 😅 i might take a stab at a more minimal harness since a lot of the dependencies seem pretty overkill. it should be possible to extract the test vectors in some pre-publishing step and then generate rust code representing them. filtering could use something like |
hiya 👋. very nice project! i'm planning on using it in a smol static file server that i'm working on
toml_test_harnessprovides a test harness backed by the officialtoml_testtest vectors. of course there are quite a few failures (over 700 tests after all), but it's easy enough to ignore failures (i tried to group them into categories too)i'd be more than happy to help fix up some of the bugs too of course :D