deps: libuv: cherry-pick aabb7651de#62561
Conversation
|
Review requested:
|
nodejs-github-bot
added
libuv
aduh95
added
dont-land-on-v20.x
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
aduh95
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/62561 ✔ Done loading data for nodejs/node/pull/62561 ----------------------------------- PR info ------------------------------------ Title deps: libuv: cherry-pick aabb7651de (#62561) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:libuv-fix -> nodejs:main Labels libuv, author ready, needs-ci, commit-queue-rebase, dont-land-on-v25.x Commits 2 - deps: libuv: reapply 3a9a6e3e6b - deps: libuv: cherry-pick aabb7651de Committers 1 - Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/62561 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62561 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 02 Apr 2026 10:41:48 GMT ✔ Approvals: 3 ✔ - René (@Renegade334): https://github.com/nodejs/node/pull/62561#pullrequestreview-4049866217 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/62561#pullrequestreview-4052355536 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/62561#pullrequestreview-4052359240 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-04-02T13:36:33Z: https://ci.nodejs.org/job/node-test-pull-request/72423/ - Querying data for job/node-test-pull-request/72423/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 62561 From https://github.com/nodejs/node * branch refs/pull/62561/merge -> FETCH_HEAD ✔ Fetched commits as 6d954e7bbbc4..28414fc67882 -------------------------------------------------------------------------------- [main 6feaad8c92] deps: libuv: reapply 3a9a6e3e6b Author: Andy Pan <i@andypan.me> Date: Wed May 21 14:43:53 2025 +0800 8 files changed, 199 insertions(+), 59 deletions(-) [main f3f237f1fb] deps: libuv: cherry-pick aabb7651de Author: Santiago Gimeno <santiago.gimeno@gmail.com> Date: Thu Apr 2 11:44:25 2026 +0200 1 file changed, 2 insertions(+) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. (node:393) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- deps: libuv: reapply 3a9a6e3e6bhttps://github.com/nodejs/node/actions/runs/23977342246 |
Original commit message: tcp: support customizing TCP_KEEPINTVL and TCP_KEEPCNT Implement `uv_tcp_keepalive_ex` function that extends `uv_tcp_keepalive` to support `TCP_KEEPINTVL` and `TCP_KEEPCN` socket options in addition to TCP_KEEPIDLE. Refs: libuv/libuv@3a9a6e3 PR-URL: nodejs#62561 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Original commit message: win: properly initialize OSVERSIONINFOW (nodejs#5107) Otherwise calling `RtlGetVersion()` might produce UB. Problem was causing random crashes in the node.js test suite with stack traces like this one: ``` node.exe!__report_gsfailure(unsigned __int64 stack_cookie) Line 220 at D:\a\_work\1\s\src\vctools\crt\vcstartup\src\gs\gs_report.c(220) ... ``` Fixes: libuv/libuv#5106 Refs: libuv/libuv@aabb765 PR-URL: nodejs#62561 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
|
Landed in dec5973...12249cc |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62561 +/- ##
==========================================
+ Coverage 89.70% 91.53% +1.82%
==========================================
Files 695 352 -343
Lines 214524 147833 -66691
Branches 41080 23148 -17932
==========================================
- Hits 192443 135321 -57122
+ Misses 14121 12255 -1866
+ Partials 7960 257 -7703 🚀 New features to boost your workflow:
|
7 participants
Refs: #62497 (comment)