Skip to content

src: improve url error handling for triggered assertions#62521

Open
wooffie wants to merge 2 commits intonodejs:mainfrom
wooffie:fix-url-asserts
Open

src: improve url error handling for triggered assertions#62521
wooffie wants to merge 2 commits intonodejs:mainfrom
wooffie:fix-url-asserts

Conversation

@wooffie
Copy link
Copy Markdown
Contributor

@wooffie wooffie commented Mar 31, 2026

Follow up dabb2f5 for two assertion crashes that not considered as security issues

Lets discuss changes and make it great

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Mar 31, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.71%. Comparing base (bf452bb) to head (0e28c2d).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/node_url.cc 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #62521   +/-   ##
=======================================
  Coverage   89.71%   89.71%           
=======================================
  Files         694      694           
  Lines      214216   214218    +2     
  Branches    41114    41118    +4     
=======================================
+ Hits       192176   192179    +3     
- Misses      14106    14107    +1     
+ Partials     7934     7932    -2     
Files with missing lines Coverage Δ
src/node_url.cc 78.41% <50.00%> (+0.11%) ⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants