Skip to content

module: emit experimental warning for module.register()#62518

Closed
GeoffreyBooth wants to merge 1 commit intonodejs:mainfrom
GeoffreyBooth:module-register-experimental-warning
Closed

module: emit experimental warning for module.register()#62518
GeoffreyBooth wants to merge 1 commit intonodejs:mainfrom
GeoffreyBooth:module-register-experimental-warning

Conversation

@GeoffreyBooth
Copy link
Copy Markdown
Member

@GeoffreyBooth GeoffreyBooth commented Mar 31, 2026

Alternative to #62401. Adds an experimental warning to module.register(), without deprecating it.

@GeoffreyBooth GeoffreyBooth added module Issues and PRs related to the module subsystem. tsc-agenda Issues and PRs to discuss during the meetings of the TSC. loaders Issues and PRs related to ES module loaders labels Mar 31, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Mar 31, 2026
@GeoffreyBooth GeoffreyBooth force-pushed the module-register-experimental-warning branch from 33a7c62 to 214b8e0 Compare March 31, 2026 01:46
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.70%. Comparing base (7ffbb76) to head (792a8bf).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62518      +/-   ##
==========================================
- Coverage   89.70%   89.70%   -0.01%     
==========================================
  Files         692      694       +2     
  Lines      214039   214228     +189     
  Branches    41064    41113      +49     
==========================================
+ Hits       192010   192178     +168     
- Misses      14091    14112      +21     
  Partials     7938     7938              
Files with missing lines Coverage Δ
lib/internal/modules/esm/loader.js 98.78% <100.00%> (+0.01%) ⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GeoffreyBooth GeoffreyBooth force-pushed the module-register-experimental-warning branch from 214b8e0 to 792a8bf Compare March 31, 2026 05:39
@GeoffreyBooth GeoffreyBooth force-pushed the module-register-experimental-warning branch from 792a8bf to ffd4351 Compare March 31, 2026 15:02
@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented Mar 31, 2026

That API is no longer experimental

@aduh95 aduh95 closed this Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. tsc-agenda Issues and PRs to discuss during the meetings of the TSC.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants