doc: clarify setTimeout millisecond precision behavior#62468
Open
vijaygovindaraja wants to merge 1 commit intonodejs:mainfrom
Open
doc: clarify setTimeout millisecond precision behavior#62468vijaygovindaraja wants to merge 1 commit intonodejs:mainfrom
vijaygovindaraja wants to merge 1 commit intonodejs:mainfrom
Conversation
Document that timer delays are tracked with millisecond precision internally, and that callbacks may appear to fire up to 1ms early when measured with sub-millisecond clocks (process.hrtime(), performance.now()). This is caused by rounding at the millisecond boundary and is most noticeable when timers interact with setImmediate() or other I/O. Refs: nodejs#26578 Signed-off-by: V Govindarajan <vijay.govindarajan91@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timer delays are tracked with millisecond precision internally. When
measured with sub-millisecond clocks (
process.hrtime(),performance.now()), callbacks may appear to fire up to 1ms earlydue to rounding at the millisecond boundary.
This has been a source of confusion for 7+ years (see #26578). Rather
than changing the timer implementation, this documents the existing
behavior so users understand the precision guarantee.
Approach discussed and endorsed by @apapirovski in #62466.
Refs: #26578