[v24.x backport] raw key formats support in KeyObject APIs#62455
Open
panva wants to merge 2 commits intonodejs:v24.x-stagingfrom
Open
[v24.x backport] raw key formats support in KeyObject APIs#62455panva wants to merge 2 commits intonodejs:v24.x-stagingfrom
panva wants to merge 2 commits intonodejs:v24.x-stagingfrom
Conversation
panva
added
crypto
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
panva
force-pushed
the
backport-62240-to-v24.x
branch
from
5c4faaa to
343e82c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v24.x-staging #62455 +/- ##
=================================================
- Coverage 90.10% 90.09% -0.02%
=================================================
Files 667 670 +3
Lines 199019 200740 +1721
Branches 38911 39223 +312
=================================================
+ Hits 179335 180863 +1528
- Misses 12040 12162 +122
- Partials 7644 7715 +71
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
panva
force-pushed
the
backport-62240-to-v24.x
branch
from
343e82c to
d0ecd5f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
PR-URL: nodejs#62240 Reviewed-By: James M Snell <jasnell@gmail.com>
panva
force-pushed
the
backport-62240-to-v24.x
branch
from
d0ecd5f to
8db948b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
panva
changed the title
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: nodejs#62480 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
panva
added
the
commit-queue-rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #62240 (partially) and #62480 to v24.x
The omitted portion of #62240 is the removal and cleanup of
KeyExportJobuse in WebCryptoAPI.