Skip to content

deps: V8: cherry-pick b25cd62c7ba2#62354

Merged
aduh95 merged 1 commit intonodejs:mainfrom
mertcanaltin:mert/v8-backport-utf8length-simdutf-v2
Mar 28, 2026
Merged

deps: V8: cherry-pick b25cd62c7ba2#62354
aduh95 merged 1 commit intonodejs:mainfrom
mertcanaltin:mert/v8-backport-utf8length-simdutf-v2

Conversation

@mertcanaltin
Copy link
Copy Markdown
Member

@mertcanaltin mertcanaltin commented Mar 20, 2026 •
edited
Loading

Backport V8 upstream commit b25cd62c7ba2 using git node v8 backport.

refs:
#61601
#62349

original commit: v8/v8@b25cd62c7ba2 @anonrig

fyi @aduh95 @Renegade334

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 20, 2026

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Mar 20, 2026
@mertcanaltin mertcanaltin mentioned this pull request Mar 20, 2026
Closed
aduh95
aduh95 previously approved these changes Mar 20, 2026
View reviewed changes
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 20, 2026
@anonrig
Copy link
Copy Markdown
Member

anonrig commented Mar 20, 2026

For reference here's the original commit: v8/v8@b25cd62c7ba2

anonrig
anonrig previously approved these changes Mar 20, 2026
View reviewed changes
@Renegade334
Copy link
Copy Markdown
Member

Renegade334 commented Mar 20, 2026 •
edited
Loading

Probably better if the base were changed to v25.x-staging rather than main, so as not to clash with the V8 update PR for v26.x, otherwise LGTM.

@mertcanaltin mertcanaltin changed the base branch from main to v25.x-staging March 20, 2026 16:03
@mertcanaltin mertcanaltin requested a review from a team as a code owner March 20, 2026 16:03
@mertcanaltin
Copy link
Copy Markdown
Member Author

mertcanaltin commented Mar 20, 2026 •
edited
Loading

Probably better if the base were changed to v25.x-staging rather than main, so as not to clash with the V8 update PR for v26.x, otherwise LGTM.

Good point, thanks, I will edit rebase problem

@Renegade334
Copy link
Copy Markdown
Member

Renegade334 commented Mar 20, 2026 •
edited
Loading

(you'll need to reset your local branch to v25.x-staging, cherry-pick your backport commit 22a6e58 to it, and force push)

@mertcanaltin mertcanaltin force-pushed the mert/v8-backport-utf8length-simdutf-v2 branch from 22a6e58 to c13a613 Compare March 20, 2026 16:12
@mertcanaltin
Copy link
Copy Markdown
Member Author

mertcanaltin commented Mar 20, 2026

(you'll need to reset your local branch to v25.x-staging, cherry-pick your backport commit 22a6e58 to it, and force push)

solved 🎉

@Renegade334 Renegade334 added the v25.x Issues that can be reproduced on v25.x or PRs targeting the v25.x-staging branch. label Mar 20, 2026
@Renegade334 Renegade334 changed the title deps: V8: cherry-pick b25cd62c7ba2 [v25.x] deps: V8: cherry-pick b25cd62c7ba2 Mar 20, 2026
Renegade334
Renegade334 previously approved these changes Mar 20, 2026
View reviewed changes
@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented Mar 20, 2026

Probably better if the base were changed to v25.x-staging rather than main, so as not to clash with the V8 update PR for v26.x, otherwise LGTM.

I disagree, it's much better to land on main unless it cannot be done

@aduh95 aduh95 changed the base branch from v25.x-staging to main March 24, 2026 14:05
@aduh95 aduh95 dismissed stale reviews from Renegade334, anonrig, and themself March 24, 2026 14:05

The base branch was changed.

@aduh95 aduh95 changed the title [v25.x] deps: V8: cherry-pick b25cd62c7ba2 deps: V8: cherry-pick b25cd62c7ba2 Mar 24, 2026
@aduh95 aduh95 force-pushed the mert/v8-backport-utf8length-simdutf-v2 branch from c13a613 to 22a6e58 Compare March 24, 2026 14:06
@aduh95 aduh95 removed the request for review from a team March 24, 2026 14:07
@aduh95 aduh95 added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Mar 24, 2026
@aduh95 aduh95 removed the v25.x Issues that can be reproduced on v25.x or PRs targeting the v25.x-staging branch. label Mar 24, 2026
@panva panva removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 25, 2026
@aduh95 aduh95 force-pushed the mert/v8-backport-utf8length-simdutf-v2 branch from 341d473 to e4361d4 Compare March 27, 2026 09:32
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 27, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72071/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 27, 2026

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7091/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 27, 2026

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7091/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 27, 2026

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7091/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 27, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72093/

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 27, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72117/

@anonrig @aduh95
deps: V8: cherry-pick b25cd62c7ba2
8ea96e6 
Original commit message:

    Optimize utf8length for utf16 values

    Change-Id: I4d9546ab45264852f52361123e86fa3b38d79e45
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7142019
    Reviewed-by: Anton Bikineev <bikineev@chromium.org>
    Reviewed-by: Erik Corry <erikcorry@chromium.org>
    Commit-Queue: Erik Corry <erikcorry@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#103754}

Refs: v8/v8@b25cd62
PR-URL: nodejs#62354
Refs: nodejs#61601
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@aduh95 aduh95 force-pushed the mert/v8-backport-utf8length-simdutf-v2 branch from e4361d4 to 8ea96e6 Compare March 28, 2026 13:44
@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented Mar 28, 2026

Landed in 8ea96e6

@aduh95 aduh95 merged commit 8ea96e6 into nodejs:main Mar 28, 2026
19 checks passed
aduh95 pushed a commit that referenced this pull request Mar 28, 2026
@anonrig @aduh95
deps: V8: cherry-pick b25cd62c7ba2
54d3d0e 
Original commit message:

    Optimize utf8length for utf16 values

    Change-Id: I4d9546ab45264852f52361123e86fa3b38d79e45
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7142019
    Reviewed-by: Anton Bikineev <bikineev@chromium.org>
    Reviewed-by: Erik Corry <erikcorry@chromium.org>
    Commit-Queue: Erik Corry <erikcorry@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#103754}

Refs: v8/v8@b25cd62
PR-URL: #62354
Refs: #61601
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.55%. Comparing base (cf2b05c) to head (8ea96e6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #62354      +/-   ##
==========================================
+ Coverage   89.70%   91.55%   +1.85%     
==========================================
  Files         691      350     -341     
  Lines      213943   147610   -66333     
  Branches    41039    23212   -17827     
==========================================
- Hits       191909   135139   -56770     
+ Misses      14089    12217    -1872     
+ Partials     7945      254    -7691

see 460 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95 pushed a commit that referenced this pull request Mar 28, 2026
@anonrig @aduh95
deps: V8: cherry-pick b25cd62c7ba2
294d8a9 
Original commit message:

    Optimize utf8length for utf16 values

    Change-Id: I4d9546ab45264852f52361123e86fa3b38d79e45
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7142019
    Reviewed-by: Anton Bikineev <bikineev@chromium.org>
    Reviewed-by: Erik Corry <erikcorry@chromium.org>
    Commit-Queue: Erik Corry <erikcorry@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#103754}

Refs: v8/v8@b25cd62
PR-URL: #62354
Refs: #61601
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request Mar 28, 2026
@anonrig @aduh95
deps: V8: cherry-pick b25cd62c7ba2
de097a2 
Original commit message:

    Optimize utf8length for utf16 values

    Change-Id: I4d9546ab45264852f52361123e86fa3b38d79e45
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7142019
    Reviewed-by: Anton Bikineev <bikineev@chromium.org>
    Reviewed-by: Erik Corry <erikcorry@chromium.org>
    Commit-Queue: Erik Corry <erikcorry@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#103754}

Refs: v8/v8@b25cd62
PR-URL: #62354
Refs: #61601
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes

@Renegade334 Renegade334 Renegade334 approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mertcanaltin @nodejs-github-bot @anonrig @Renegade334 @aduh95 @panva