lib,src,test,doc: add node:ffi module by cjihrig · Pull Request #62072 · nodejs/node

cjihrig · 2026-03-02T14:43:52Z

This is not ready for review yet. Just opening to see if this is something the project is still interested in.

nodejs-github-bot · 2026-03-02T14:43:58Z

Review requested:

@nodejs/gyp
@nodejs/security-wg

anonrig · 2026-03-02T16:00:18Z

Yes

Qard

Looks very cool! I'm glad to see someone has picked this back up. 🙂

I did a quick review and it all looks good. My only comment is there seems to be a bunch of static strings and a private symbol which we might want to define in env_properties.h.

src/node_ffi.cc

github-actions · 2026-03-18T23:43:23Z

Failed to start CI

   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/23272564448

nodejs-github-bot · 2026-03-18T23:44:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71877/

nodejs-github-bot · 2026-03-18T23:54:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71878/

cjihrig · 2026-03-18T23:59:59Z

@anonrig I cancelled that CI run to save resources. I started https://ci.nodejs.org/job/node-test-pull-request/71877/ manually, and it's currently running.

@cjihrig

given that this is still draft and @cjihrig indicated it's not ready for review, a sign off is not yet appropriate.

mcollina

lgtm

nodejs-github-bot · 2026-03-19T03:10:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71884/

@cjihrig

given that this is still draft and @cjihrig indicated it's not ready for review, a sign off is not yet appropriate.

jasnell · 2026-03-19T03:41:32Z

@cjihrig ... definitely interested in seeing ffi land. I was hoping @bengl's prior efforts would make progress. Once you feel this is ready to go, I'll be happy to review.

mcollina

lgtm

mcollina · 2026-04-01T17:27:16Z

@cjihrig @ShogunPanda this now conflicts, can you rebase?

codecov · 2026-04-02T16:06:16Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.17%. Comparing base (e775989) to head (e04304c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62072      +/-   ##
==========================================
- Coverage   89.71%   89.17%   -0.55%     
==========================================
  Files         695      702       +7     
  Lines      214546   216183    +1637     
  Branches    41082    41436     +354     
==========================================
+ Hits       192487   192780     +293     
- Misses      14116    15444    +1328     
- Partials     7943     7959      +16

Files with missing lines	Coverage Δ
lib/ffi.js	`95.73% <ø> (ø)`
lib/internal/bootstrap/realm.js	`96.21% <ø> (+<0.01%)`	⬆️
lib/internal/process/permission.js	`100.00% <ø> (ø)`
lib/internal/process/pre_execution.js	`98.63% <ø> (+1.40%)`	⬆️
src/env.cc	`85.45% <ø> (+0.26%)`	⬆️
src/ffi/data.cc	`5.30% <ø> (ø)`
src/ffi/types.cc	`0.00% <ø> (ø)`
src/node_binding.cc	`82.74% <ø> (ø)`
src/node_builtins.cc	`76.09% <ø> (-0.15%)`	⬇️
src/node_ffi.cc	`11.84% <ø> (ø)`
... and 8 more

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

src/node_ffi.cc

ShogunPanda · 2026-04-02T18:45:17Z

@jasnell Thanks for the review, tomorrow (CEST) I'll address all of them.
Does the architecture and API look fine to you?

mcollina

lgtm

nodejs-github-bot · 2026-04-03T15:11:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72455/

jasnell · 2026-04-03T15:31:56Z

... Does the architecture and API look fine to you?

At first glance, looks fine. I can do another review pass in the next day or two

nodejs-github-bot · 2026-04-04T07:08:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72463/

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

* src,deps,test: various improvements Signed-off-by: Paolo Insogna <paolo@cowtech.it> * deps,test: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * deps,test: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * deps,test: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * deps,test: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * doc,lib: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * deps: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> * test: fixed failures Signed-off-by: Paolo Insogna <paolo@cowtech.it> --------- Signed-off-by: Paolo Insogna <paolo@cowtech.it>

* test: fixed build on Windows Signed-off-by: Paolo Insogna <paolo@cowtech.it> * test: fixed build on Windows Signed-off-by: Paolo Insogna <paolo@cowtech.it> * test: fixed build on Windows Signed-off-by: Paolo Insogna <paolo@cowtech.it> * test: fixed build on Windows Signed-off-by: Paolo Insogna <paolo@cowtech.it> * test: removed useless file Signed-off-by: Paolo Insogna <paolo@cowtech.it> --------- Signed-off-by: Paolo Insogna <paolo@cowtech.it>

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

mcollina

lgtm

nodejs-github-bot · 2026-04-06T09:21:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72504/

nodejs-github-bot · 2026-04-06T10:41:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72510/

nodejs-github-bot added build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Mar 2, 2026

Qard reviewed Mar 2, 2026

View reviewed changes

src/node_ffi.cc Outdated Show resolved Hide resolved

cjihrig force-pushed the ffi branch 2 times, most recently from 9462e4d to 631d73a Compare March 10, 2026 03:46

cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2026

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 18, 2026

anonrig previously approved these changes Mar 18, 2026

View reviewed changes

anonrig added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Mar 18, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2026

mcollina previously approved these changes Mar 19, 2026

View reviewed changes

mcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 19, 2026

cjihrig marked this pull request as ready for review April 1, 2026 14:41

mcollina approved these changes Apr 1, 2026

View reviewed changes

jasnell reviewed Apr 2, 2026

View reviewed changes

src/node_ffi.cc Outdated Show resolved Hide resolved

jasnell reviewed Apr 2, 2026

View reviewed changes

src/node_ffi.cc Outdated Show resolved Hide resolved

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 3, 2026

mcollina approved these changes Apr 3, 2026

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 3, 2026

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2026

cjihrig and others added 13 commits April 6, 2026 08:12

lib,src,test,doc: add node:ffi module

285399c

ffi: Refactor to simpler API.

43d06dd

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

fix: Various improvements.

b731cf4

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

fix the build

d0251c4

fix lint

f968c32

remove test fixture readme

f19ed12

remove extra test file

22ddca5

tests

2ad47ef

src: formatted files

c44780a

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

fixup

769be84

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

fixup

e04304c

Signed-off-by: Paolo Insogna <paolo@cowtech.it>

ShogunPanda force-pushed the ffi branch from d562ab9 to e04304c Compare April 6, 2026 06:16

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2026

mcollina approved these changes Apr 6, 2026

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2026

Uh oh!

Conversation

cjihrig commented Mar 2, 2026

Uh oh!

nodejs-github-bot commented Mar 2, 2026

Uh oh!

anonrig commented Mar 2, 2026

Uh oh!

Qard left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 18, 2026

Uh oh!

nodejs-github-bot commented Mar 18, 2026

Uh oh!

nodejs-github-bot commented Mar 18, 2026

Uh oh!

cjihrig commented Mar 18, 2026

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Mar 19, 2026

Uh oh!

jasnell commented Mar 19, 2026

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina commented Apr 1, 2026

Uh oh!

codecov bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

ShogunPanda commented Apr 2, 2026

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Apr 3, 2026

Uh oh!

jasnell commented Apr 3, 2026

Uh oh!

nodejs-github-bot commented Apr 4, 2026

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Apr 6, 2026

Uh oh!

nodejs-github-bot commented Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov bot commented Apr 2, 2026 •

edited

Loading